Resolve lint issues

Differential Revision: D50205775

Pull Request resolved: https://github.com/pytorch/audio/pull/3651

src/libtorchaudio/cuctc/include/ctc_prefix_decoder.h

@@ -52,7 +52,6 @@ std::tuple<size_t, int> calculate_require_buff_and_init_internal_data(
     float threshold);
 int ctc_beam_search_decoder_batch_gpu(
     InternalData* inter_data,
-    float* pp,
     int blid,
     int spid,
     int* clist,

src/libtorchaudio/cuctc/src/bitonic_topk/pow2_utils.cuh

@@ -24,7 +24,7 @@ constexpr __device__ IntType log2(IntType num, IntType ret = IntType(0)) {
  */
 template <auto Value_>
 struct Pow2 {
-  typedef decltype(Value_) Type;
+  using Type = decltype(Value_);
   static constexpr Type Value = Value_;
   static constexpr Type Log2 = log2(Value);
   static constexpr Type Mask = Value - 1;

src/libtorchaudio/cuctc/src/ctc_prefix_decoder.cpp

@@ -72,8 +72,9 @@ std::tuple<size_t, int> calculate_require_buff_and_init_internal_data(
     const std::vector<int>& prob_strides,
     int blid,
     float threshold) {
-  if ((batch_size * beam * seq_len * vocab_size) <= 0)
+  if ((batch_size * beam * seq_len * vocab_size) <= 0) {
     return {0, 0};
+  }
 
   CHECK(prob_sizes.size() == 3, "only support 3D log_prob.");
   CHECK(prob_strides.size() == 3, "only support 3D log_prob. ");
@@ -123,8 +124,9 @@ std::tuple<size_t, int> calculate_require_buff_and_init_internal_data(
   require_size += select_seq_lens_align_size;
 
   require_size += ALIGN_BYTES;
-  if (require_size > buff_size)
+  if (require_size > buff_size) {
     return {require_size, 0};
+  }
 
   char* buff_align_ptr = reinterpret_cast<char*>(align_size(buff_ptr));
 
@@ -291,7 +293,6 @@ void prefixCTC_free(std::uintptr_t inter_data_ptr) {
 
 int ctc_beam_search_decoder_batch_gpu(
     InternalData* inter_data,
-    float* pp,
     int blid,
     int spid,
     int* clist,

src/libtorchaudio/cuctc/src/device_data_wrap.h

@@ -35,9 +35,9 @@ constexpr int MAX_BLOCKS = 800;
 template <typename T>
 class DeviceDataWrap {
  public:
-  DeviceDataWrap() : data_{}, size_in_bytes_{} {};
+  DeviceDataWrap() : data_{}, size_in_bytes_{} {}
   DeviceDataWrap(T* data_ptr, size_t size_in_byte)
-      : data_{data_ptr}, size_in_bytes_{size_in_byte} {};
+      : data_{data_ptr}, size_in_bytes_{size_in_byte} {}
   void print(size_t offset, size_t size_in_element, int eles_per_row = 10)
       const {
     if ((offset + size_in_element) * sizeof(T) > size_in_bytes_) {

src/libtorchaudio/cuctc/src/python_binding.cpp

@@ -70,13 +70,7 @@ ctc_prefix_decoder_batch_wrapper(
   std::vector<int> len_data(batch_size * beam);
   std::vector<float> score(batch_size * beam);
   cu_ctc::ctc_beam_search_decoder_batch_gpu(
-      inter_data,
-      (float*)pp,
-      blid,
-      spid,
-      list_data.data(),
-      len_data.data(),
-      score.data());
+      inter_data, blid, spid, list_data.data(), len_data.data(), score.data());
   SCORE_TYPE score_hyps{};
   score_hyps.reserve(batch_size);
   for (int b = 0; b < batch_size; b++) {

src/libtorchaudio/forced_align/cpu/compute.cpp

@@ -116,11 +116,9 @@ void forced_align_impl(
   auto idx1 = (T - 1) % 2;
   auto ltrIdx = alphas_a[idx1][S - 1] > alphas_a[idx1][S - 2] ? S - 1 : S - 2;
   // path stores the token index for each time step after force alignment.
-  auto indexScores = 0;
   for (auto t = T - 1; t > -1; t--) {
     auto lbl_idx = ltrIdx % 2 == 0 ? blank : targets_a[batchIndex][ltrIdx / 2];
     paths_a[batchIndex][t] = lbl_idx;
-    ++indexScores;
     ltrIdx -= backPtr_a[t][ltrIdx];
   }
 }

src/libtorchaudio/rir/wall.h

+#pragma once
 #include <torch/types.h>
 
 #define EPS ((scalar_t)(1e-5))
@@ -77,9 +78,9 @@ scalar_t cosine(const Wall<scalar_t>& wall, const torch::Tensor& dir) {
 /// 3D room
 template <typename T>
 const std::array<Wall<T>, 6> make_room(
-    const T w,
-    const T l,
-    const T h,
+    const T& w,
+    const T& l,
+    const T& h,
     const torch::Tensor& abs,
     const torch::Tensor& scat) {
   using namespace torch::indexing;

src/libtorchaudio/rnnt/cpu/cpu_kernels.h

@@ -165,7 +165,6 @@ status_t ComputeLogProbs(
 
 template <typename DTYPE>
 DTYPE ComputeAlphaOneSequence(
-    const Options& options,
     TensorView<const LogProbs<DTYPE>>& logProbs,
     int srcLen,
     int tgtLen,
@@ -198,7 +197,6 @@ DTYPE ComputeAlphaOneSequence(
 
 template <typename DTYPE>
 DTYPE ComputeBetaOneSequence(
-    const Options& options,
     TensorView<const LogProbs<DTYPE>>& logProbs,
     int srcLen,
     int tgtLen,
@@ -240,14 +238,12 @@ DTYPE ComputeAlphaOrBetaOneSequence(
     TensorView<DTYPE>& beta) {
   if (thread & 1) {
     return ComputeAlphaOneSequence<DTYPE>(
-        /*options=*/options,
         /*logProbs=*/logProbs,
         /*srcLen=*/srcLen,
         /*tgtLen=*/tgtLen,
         /*alpha=*/alpha);
   } else {
     return ComputeBetaOneSequence<DTYPE>(
-        /*options=*/options,
         /*logProbs=*/logProbs,
         /*srcLen=*/srcLen,
         /*tgtLen=*/tgtLen,
@@ -488,7 +484,6 @@ void ComputeAlphas(
   //#pragma omp parallel for
   for (int i = 0; i < B; ++i) { // use max 2 * B threads.
     ComputeAlphaOneSequence<DTYPE>(
-        options,
         /*logProbs=*/seqlogProbs[i],
         /*srcLen=*/srcLengths[i],
         /*tgtLen=*/tgtLengths[i] + 1, // with prepended blank.
@@ -524,7 +519,6 @@ void ComputeBetas(
   //#pragma omp parallel for
   for (int i = 0; i < B; ++i) {
     ComputeBetaOneSequence<DTYPE>(
-        options,
         /*logProbs=*/seqlogProbs[i],
         /*srcLen=*/srcLengths[i],
         /*tgtLen=*/tgtLengths[i] + 1, // with prepended blank.

src/libtorchaudio/rnnt/cpu/math.h

@@ -10,18 +10,20 @@ namespace math {
 
 template <typename DTYPE>
 FORCE_INLINE HOST_AND_DEVICE DTYPE max(DTYPE x, DTYPE y) {
-  if (x > y)
+  if (x > y) {
     return x;
-  else
+  } else {
     return y;
+  }
 }
 
 template <typename DTYPE>
 FORCE_INLINE HOST_AND_DEVICE DTYPE min(DTYPE x, DTYPE y) {
-  if (x > y)
+  if (x > y) {
     return y;
-  else
+  } else {
     return x;
+  }
 }
 
 // log_sum_exp

src/libtorchaudio/rnnt/macros.cpp

-#include <libtorchaudio/rnnt/macros.h>
-
-const char* ToString(level_t level) {
-  switch (level) {
-    case INFO:
-      return "INFO";
-    case WARNING:
-      return "WARNING";
-    case ERROR:
-      return "ERROR";
-    case FATAL:
-      return "FATAL";
-    default:
-      return "UNKNOWN";
-  }
-}

src/libtorchaudio/rnnt/macros.h

@@ -12,10 +12,3 @@
 #define HOST_AND_DEVICE
 #define FORCE_INLINE inline
 #endif // USE_CUDA
-
-#include <cstring>
-#include <iostream>
-
-typedef enum { INFO = 0, WARNING = 1, ERROR = 2, FATAL = 3 } level_t;
-
-const char* ToString(level_t level);

src/libtorchaudio/rnnt/options.h

 #pragma once
 
-//#include <iostream>
-
 #ifdef USE_CUDA
 #include <cuda_runtime.h>
 #endif // USE_CUDA
 
-#include <libtorchaudio/rnnt/macros.h>
 #include <libtorchaudio/rnnt/types.h>
+#include <ostream>
 
 namespace torchaudio {
 namespace rnnt {
 
-typedef struct Options {
+struct Options {
   // the device to compute transducer loss.
   device_t device_;
 #ifdef USE_CUDA
@@ -78,7 +76,7 @@ typedef struct Options {
 
     return os;
   }
-} Options;
+};
 
 } // namespace rnnt
 } // namespace torchaudio

src/libtorchaudio/rnnt/types.cpp

-#include <libtorchaudio/rnnt/types.h>
-
-namespace torchaudio {
-namespace rnnt {
-
-const char* toString(status_t status) {
-  switch (status) {
-    case SUCCESS:
-      return "success";
-    case FAILURE:
-      return "failure";
-    case COMPUTE_DENOMINATOR_REDUCE_MAX_FAILED:
-      return "compute_denominator_reduce_max_failed";
-    case COMPUTE_DENOMINATOR_REDUCE_SUM_FAILED:
-      return "compute_denominator_reduce_sum_failed";
-    case COMPUTE_LOG_PROBS_FAILED:
-      return "compute_log_probs_failed";
-    case COMPUTE_ALPHAS_BETAS_COSTS_FAILED:
-      return "compute_alphas_betas_costs_failed";
-    case COMPUTE_GRADIENTS_FAILED:
-      return "compute_gradients_failed";
-    default:
-      return "unknown";
-  }
-}
-
-const char* toString(device_t device) {
-  switch (device) {
-    case UNDEFINED:
-      return "undefined";
-    case CPU:
-      return "cpu";
-    case GPU:
-      return "gpu";
-    default:
-      return "unknown";
-  }
-}
-
-} // namespace rnnt
-} // namespace torchaudio

src/libtorchaudio/rnnt/types.h

@@ -3,7 +3,7 @@
 namespace torchaudio {
 namespace rnnt {
 
-typedef enum {
+enum status_t {
   SUCCESS = 0,
   FAILURE = 1,
   COMPUTE_DENOMINATOR_REDUCE_MAX_FAILED = 2,
@@ -11,13 +11,9 @@ typedef enum {
   COMPUTE_LOG_PROBS_FAILED = 4,
   COMPUTE_ALPHAS_BETAS_COSTS_FAILED = 5,
   COMPUTE_GRADIENTS_FAILED = 6
-} status_t;
+};
 
-typedef enum { UNDEFINED = 0, CPU = 1, GPU = 2 } device_t;
-
-const char* toString(status_t status);
-
-const char* toString(device_t device);
+enum device_t { UNDEFINED = 0, CPU = 1, GPU = 2 };
 
 } // namespace rnnt
 } // namespace torchaudio

src/libtorchaudio/sox/effects_chain.cpp

@@ -129,14 +129,14 @@ int file_output_flow(
 sox_effect_handler_t* get_tensor_input_handler() {
   static sox_effect_handler_t handler{
       /*name=*/"input_tensor",
-      /*usage=*/NULL,
+      /*usage=*/nullptr,
       /*flags=*/SOX_EFF_MCHAN,
-      /*getopts=*/NULL,
-      /*start=*/NULL,
-      /*flow=*/NULL,
+      /*getopts=*/nullptr,
+      /*start=*/nullptr,
+      /*flow=*/nullptr,
       /*drain=*/tensor_input_drain,
-      /*stop=*/NULL,
-      /*kill=*/NULL,
+      /*stop=*/nullptr,
+      /*kill=*/nullptr,
       /*priv_size=*/sizeof(TensorInputPriv)};
   return &handler;
 }
@@ -144,14 +144,14 @@ sox_effect_handler_t* get_tensor_input_handler() {
 sox_effect_handler_t* get_tensor_output_handler() {
   static sox_effect_handler_t handler{
       /*name=*/"output_tensor",
-      /*usage=*/NULL,
+      /*usage=*/nullptr,
       /*flags=*/SOX_EFF_MCHAN,
-      /*getopts=*/NULL,
-      /*start=*/NULL,
+      /*getopts=*/nullptr,
+      /*start=*/nullptr,
       /*flow=*/tensor_output_flow,
-      /*drain=*/NULL,
-      /*stop=*/NULL,
-      /*kill=*/NULL,
+      /*drain=*/nullptr,
+      /*stop=*/nullptr,
+      /*kill=*/nullptr,
       /*priv_size=*/sizeof(TensorOutputPriv)};
   return &handler;
 }
@@ -159,14 +159,14 @@ sox_effect_handler_t* get_tensor_output_handler() {
 sox_effect_handler_t* get_file_output_handler() {
   static sox_effect_handler_t handler{
       /*name=*/"output_file",
-      /*usage=*/NULL,
+      /*usage=*/nullptr,
       /*flags=*/SOX_EFF_MCHAN,
-      /*getopts=*/NULL,
-      /*start=*/NULL,
+      /*getopts=*/nullptr,
+      /*start=*/nullptr,
       /*flow=*/file_output_flow,
-      /*drain=*/NULL,
-      /*stop=*/NULL,
-      /*kill=*/NULL,
+      /*drain=*/nullptr,
+      /*stop=*/nullptr,
+      /*kill=*/nullptr,
       /*priv_size=*/sizeof(FileOutputPriv)};
   return &handler;
 }
@@ -208,7 +208,7 @@ SoxEffectsChain::~SoxEffectsChain() {
 }
 
 void SoxEffectsChain::run() {
-  sox_flow_effects(sec_, NULL, NULL);
+  sox_flow_effects(sec_, nullptr, nullptr);
 }
 
 void SoxEffectsChain::addInputTensor(
@@ -259,7 +259,7 @@ void SoxEffectsChain::addOutputFile(sox_format_t* sf) {
       sf->filename);
 }
 
-void SoxEffectsChain::addEffect(const std::vector<std::string> effect) {
+void SoxEffectsChain::addEffect(const std::vector<std::string>& effect) {
   const auto num_args = effect.size();
   TORCH_CHECK(num_args != 0, "Invalid argument: empty effect.");
   const auto name = effect[0];

src/libtorchaudio/sox/effects_chain.h

@@ -12,7 +12,7 @@ namespace torchaudio::sox {
 struct SoxEffect {
   explicit SoxEffect(sox_effect_t* se) noexcept;
   SoxEffect(const SoxEffect& other) = delete;
-  SoxEffect(const SoxEffect&& other) = delete;
+  SoxEffect(SoxEffect&& other) = delete;
   auto operator=(const SoxEffect& other) -> SoxEffect& = delete;
   auto operator=(SoxEffect&& other) -> SoxEffect& = delete;
   ~SoxEffect();
@@ -39,7 +39,7 @@ class SoxEffectsChain {
       sox_encodinginfo_t input_encoding,
       sox_encodinginfo_t output_encoding);
   SoxEffectsChain(const SoxEffectsChain& other) = delete;
-  SoxEffectsChain(const SoxEffectsChain&& other) = delete;
+  SoxEffectsChain(SoxEffectsChain&& other) = delete;
   SoxEffectsChain& operator=(const SoxEffectsChain& other) = delete;
   SoxEffectsChain& operator=(SoxEffectsChain&& other) = delete;
   ~SoxEffectsChain();
@@ -51,7 +51,7 @@ class SoxEffectsChain {
   void addInputFile(sox_format_t* sf);
   void addOutputBuffer(std::vector<sox_sample_t>* output_buffer);
   void addOutputFile(sox_format_t* sf);
-  void addEffect(const std::vector<std::string> effect);
+  void addEffect(const std::vector<std::string>& effect);
   int64_t getOutputNumChannels();
   int64_t getOutputSampleRate();
 };

src/libtorchaudio/sox/io.cpp

@@ -78,8 +78,9 @@ void save_audio_file(
   validate_input_tensor(tensor);
 
   const auto filetype = [&]() {
-    if (format.has_value())
+    if (format.has_value()) {
       return format.value();
+    }
     return get_filetype(path);
   }();
 

src/libtorchaudio/sox/types.cpp

@@ -3,26 +3,36 @@
 namespace torchaudio::sox {
 
 Format get_format_from_string(const std::string& format) {
-  if (format == "wav")
+  if (format == "wav") {
     return Format::WAV;
-  if (format == "mp3")
+  }
+  if (format == "mp3") {
     return Format::MP3;
-  if (format == "flac")
+  }
+  if (format == "flac") {
     return Format::FLAC;
-  if (format == "ogg" || format == "vorbis")
+  }
+  if (format == "ogg" || format == "vorbis") {
     return Format::VORBIS;
-  if (format == "amr-nb")
+  }
+  if (format == "amr-nb") {
     return Format::AMR_NB;
-  if (format == "amr-wb")
+  }
+  if (format == "amr-wb") {
     return Format::AMR_WB;
-  if (format == "amb")
+  }
+  if (format == "amb") {
     return Format::AMB;
-  if (format == "sph")
+  }
+  if (format == "sph") {
     return Format::SPHERE;
-  if (format == "htk")
+  }
+  if (format == "htk") {
     return Format::HTK;
-  if (format == "gsm")
+  }
+  if (format == "gsm") {
     return Format::GSM;
+  }
   TORCH_CHECK(false, "Internal Error: unexpected format value: ", format);
 }
 

src/libtorchaudio/sox/utils.cpp

@@ -5,6 +5,14 @@
 
 namespace torchaudio::sox {
 
+const std::unordered_set<std::string> UNSUPPORTED_EFFECTS{
+    "input",
+    "output",
+    "spectrogram",
+    "noiseprof",
+    "noisered",
+    "splice"};
+
 void set_seed(const int64_t seed) {
   sox_get_globals()->ranqd1 = static_cast<sox_int32_t>(seed);
 }
@@ -46,10 +54,11 @@ std::vector<std::string> list_write_formats() {
   for (const sox_format_tab_t* fns = sox_get_format_fns(); fns->fn; ++fns) {
     const sox_format_handler_t* handler = fns->fn();
     for (const char* const* names = handler->names; *names; ++names) {
-      if (!strchr(*names, '/') && handler->write)
+      if (!strchr(*names, '/') && handler->write) {
         formats.emplace_back(*names);
       }
     }
+  }
   return formats;
 }
 
@@ -58,10 +67,11 @@ std::vector<std::string> list_read_formats() {
   for (const sox_format_tab_t* fns = sox_get_format_fns(); fns->fn; ++fns) {
     const sox_format_handler_t* handler = fns->fn();
     for (const char* const* names = handler->names; *names; ++names) {
-      if (!strchr(*names, '/') && handler->read)
+      if (!strchr(*names, '/') && handler->read) {
         formats.emplace_back(*names);
       }
     }
+  }
   return formats;
 }
 
@@ -193,7 +203,7 @@ const std::string get_filetype(const std::string& path) {
 namespace {
 
 std::tuple<sox_encoding_t, unsigned> get_save_encoding_for_wav(
-    const std::string format,
+    const std::string& format,
     caffe2::TypeMeta dtype,
     const Encoding& encoding,
     const BitDepth& bits_per_sample) {
@@ -386,12 +396,15 @@ std::tuple<sox_encoding_t, unsigned> get_save_encoding(
 }
 
 unsigned get_precision(const std::string& filetype, caffe2::TypeMeta dtype) {
-  if (filetype == "mp3")
+  if (filetype == "mp3") {
     return SOX_UNSPEC;
-  if (filetype == "flac")
+  }
+  if (filetype == "flac") {
     return 24;
-  if (filetype == "ogg" || filetype == "vorbis")
+  }
+  if (filetype == "ogg" || filetype == "vorbis") {
     return SOX_UNSPEC;
+  }
   if (filetype == "wav" || filetype == "amb") {
     switch (dtype.toScalarType()) {
       case c10::ScalarType::Byte:
@@ -406,8 +419,9 @@ unsigned get_precision(const std::string& filetype, caffe2::TypeMeta dtype) {
         TORCH_CHECK(false, "Unsupported dtype: ", dtype);
     }
   }
-  if (filetype == "sph")
+  if (filetype == "sph") {
     return 32;
+  }
   if (filetype == "amr-nb") {
     return 16;
   }
@@ -432,7 +446,8 @@ sox_signalinfo_t get_signalinfo(
       /*channels=*/
       static_cast<unsigned>(waveform->size(channels_first ? 0 : 1)),
       /*precision=*/get_precision(filetype, waveform->dtype()),
-      /*length=*/static_cast<uint64_t>(waveform->numel())};
+      /*length=*/static_cast<uint64_t>(waveform->numel()),
+      nullptr};
 }
 
 sox_encodinginfo_t get_tensor_encodinginfo(caffe2::TypeMeta dtype) {

src/libtorchaudio/sox/utils.h

@@ -31,8 +31,7 @@ std::vector<std::string> list_write_formats();
 // Utilities for sox_io / sox_effects implementations
 ////////////////////////////////////////////////////////////////////////////////
 
-const std::unordered_set<std::string> UNSUPPORTED_EFFECTS =
-    {"input", "output", "spectrogram", "noiseprof", "noisered", "splice"};
+extern const std::unordered_set<std::string> UNSUPPORTED_EFFECTS;
 
 /// helper class to automatically close sox_format_t*
 struct SoxFormat {