Unverified Commit d64648b6 authored by moto's avatar moto Committed by GitHub
Browse files

Deprecate data utils (#1809)

* Deprecate data utils

- The design criteria of diskcache_iterator and bg_iterator are not well-specified
- The implementation does not improve the performance due to GIL and threading
parent 8686af1f
...@@ -13,6 +13,8 @@ import torch ...@@ -13,6 +13,8 @@ import torch
from torch.utils.data import Dataset from torch.utils.data import Dataset
from torch.utils.model_zoo import tqdm from torch.utils.model_zoo import tqdm
from torchaudio._internal.module_utils import deprecated
def stream_url(url: str, def stream_url(url: str,
start_byte: Optional[int] = None, start_byte: Optional[int] = None,
...@@ -234,6 +236,7 @@ class _DiskCache(Dataset): ...@@ -234,6 +236,7 @@ class _DiskCache(Dataset):
return len(self.dataset) return len(self.dataset)
@deprecated('', version='0.11')
def diskcache_iterator(dataset: Dataset, location: str = ".cached") -> Dataset: def diskcache_iterator(dataset: Dataset, location: str = ".cached") -> Dataset:
return _DiskCache(dataset, location) return _DiskCache(dataset, location)
...@@ -276,5 +279,6 @@ class _ThreadedIterator(threading.Thread): ...@@ -276,5 +279,6 @@ class _ThreadedIterator(threading.Thread):
return self.__next__() return self.__next__()
@deprecated('', version='0.11')
def bg_iterator(iterable: Iterable, maxsize: int) -> Any: def bg_iterator(iterable: Iterable, maxsize: int) -> Any:
return _ThreadedIterator(iterable, maxsize=maxsize) return _ThreadedIterator(iterable, maxsize=maxsize)
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment