Skip to content
GitLab
Menu
Projects
Groups
Snippets
Loading...
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
Menu
Open sidebar
OpenDAS
Torchaudio
Commits
a7161298
Unverified
Commit
a7161298
authored
Oct 21, 2021
by
moto
Committed by
GitHub
Oct 21, 2021
Browse files
Remove MACOSX_DEPLOYMENT_TARGET (#1880)
It seems that this is no longer necessary for recent macOS .
parent
fe1ca374
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
3 additions
and
3 deletions
+3
-3
CONTRIBUTING.md
CONTRIBUTING.md
+1
-1
README.md
README.md
+1
-1
packaging/pkg_helpers.bash
packaging/pkg_helpers.bash
+1
-1
No files found.
CONTRIBUTING.md
View file @
a7161298
...
...
@@ -63,7 +63,7 @@ cd audio
git submodule update
--init
--recursive
python setup.py develop
# or, for OSX
#
MACOSX_DEPLOYMENT_TARGET=10.9
CC=clang CXX=clang++ python setup.py develop
# CC=clang CXX=clang++ python setup.py develop
```
Some environmnet variables that change the build behavior
...
...
README.md
View file @
a7161298
...
...
@@ -64,7 +64,7 @@ The build process also builds the RNN transducer loss. This functionality can be
python setup.py
install
# OSX
MACOSX_DEPLOYMENT_TARGET
=
10.9
CC
=
clang
CXX
=
clang++ python setup.py
install
CC
=
clang
CXX
=
clang++ python setup.py
install
# Windows
# We need to use the MSVC x64 toolset for compilation, with Visual Studio's vcvarsall.bat or directly with vcvars64.bat.
...
...
packaging/pkg_helpers.bash
View file @
a7161298
...
...
@@ -141,7 +141,7 @@ setup_build_version() {
# Set some useful variables for OS X, if applicable
setup_macos
()
{
if
[[
"
$(
uname
)
"
==
Darwin
]]
;
then
export
MACOSX_DEPLOYMENT_TARGET
=
10.9
CC
=
clang
CXX
=
clang++
export
CC
=
clang
CXX
=
clang++
fi
}
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
.
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment