Unverified Commit 9ba02d5b authored by moto's avatar moto Committed by GitHub
Browse files

[CI] Run unit test with non-editable installation (#845)

We have been running unit test with editable installation. (i.e. `python setup.py develop`), with which we missed issues like #842. 

This CC makes installation in CI non-editable, and change test directory structure so that the source code will not shadow the installed version of `torchaudio`. With simple `pytest test`, `pytest` modifies `sys.path` and prepend checked out repository, which shadows the installed version.

To remedy this, the whole test suites has been moved from `./test` to `./test/torchaudio_unittest`. This adds nice module structure to our test code and we can do absolute import in each test module, which makes it possible again to run test with `python -m unittest torchaudio_unittest/XXX.py`

This change does not affect the regular development process (`python setup.py develop` && `pytest test`)
parent 3b055890
......@@ -2,7 +2,7 @@ import os
from torchaudio.datasets import cmuarctic
from ..common_utils import (
from torchaudio_unittest.common_utils import (
TempDirMixin,
TorchaudioTestCase,
get_whitenoise,
......
......@@ -3,7 +3,7 @@ import csv
import random
from torchaudio.datasets import commonvoice
from ..common_utils import (
from torchaudio_unittest.common_utils import (
TempDirMixin,
TorchaudioTestCase,
get_whitenoise,
......
......@@ -2,7 +2,7 @@ from torchaudio.datasets.librispeech import LIBRISPEECH
from torchaudio.datasets.speechcommands import SPEECHCOMMANDS
from torchaudio.datasets.vctk import VCTK
from ..common_utils import (
from torchaudio_unittest.common_utils import (
TorchaudioTestCase,
get_asset_path,
)
......
......@@ -2,7 +2,7 @@ import os
from torchaudio.datasets import gtzan
from ..common_utils import (
from torchaudio_unittest.common_utils import (
TempDirMixin,
TorchaudioTestCase,
get_whitenoise,
......
......@@ -2,7 +2,7 @@ import os
from torchaudio.datasets import librispeech
from ..common_utils import (
from torchaudio_unittest.common_utils import (
TempDirMixin,
TorchaudioTestCase,
get_whitenoise,
......
......@@ -2,7 +2,7 @@ import os
from torchaudio.datasets.libritts import LIBRITTS
from ..common_utils import (
from torchaudio_unittest.common_utils import (
TempDirMixin,
TorchaudioTestCase,
get_whitenoise,
......
......@@ -3,7 +3,7 @@ import os
from torchaudio.datasets import ljspeech
from ..common_utils import (
from torchaudio_unittest.common_utils import (
TempDirMixin,
TorchaudioTestCase,
get_whitenoise,
......
......@@ -2,7 +2,7 @@ import os
from torchaudio.datasets import speechcommands
from ..common_utils import (
from torchaudio_unittest.common_utils import (
TempDirMixin,
TorchaudioTestCase,
get_whitenoise,
......
......@@ -4,7 +4,7 @@ from pathlib import Path
from torchaudio.datasets import utils as dataset_utils
from torchaudio.datasets.commonvoice import COMMONVOICE
from ..common_utils import (
from torchaudio_unittest.common_utils import (
TempDirMixin,
TorchaudioTestCase,
get_asset_path,
......
......@@ -2,7 +2,7 @@ import os
from torchaudio.datasets import yesno
from ..common_utils import (
from torchaudio_unittest.common_utils import (
TempDirMixin,
TorchaudioTestCase,
get_whitenoise,
......
......@@ -7,7 +7,7 @@ import torchaudio.functional as F
from parameterized import parameterized
import pytest
from . import common_utils
from torchaudio_unittest import common_utils
from .functional_impl import Lfilter
......
import torch
from . import common_utils
from torchaudio_unittest import common_utils
from .functional_impl import Lfilter
......
......@@ -2,7 +2,7 @@
import torch
import torchaudio.functional as F
from . import common_utils
from torchaudio_unittest import common_utils
class Lfilter(common_utils.TestBaseMixin):
......
......@@ -9,7 +9,7 @@ import torchaudio
from torchaudio.utils import sox_utils
from torchaudio._internal.module_utils import is_module_available
from .common_utils import get_asset_path
from torchaudio_unittest.common_utils import get_asset_path
BACKENDS = []
BACKENDS_MP3 = []
......
import torch
from . import common_utils
from torchaudio_unittest import common_utils
from .kaldi_compatibility_impl import Kaldi
......
import torch
from . import common_utils
from torchaudio_unittest import common_utils
from .kaldi_compatibility_impl import Kaldi
......
......@@ -7,7 +7,7 @@ import torchaudio.functional as F
import torchaudio.compliance.kaldi
from parameterized import parameterized
from .common_utils import (
from torchaudio_unittest.common_utils import (
TestBaseMixin,
load_params,
skipIfNoExec,
......
......@@ -3,7 +3,7 @@ import unittest
import torch
import torchaudio.kaldi_io as kio
from . import common_utils
from torchaudio_unittest import common_utils
class Test_KaldiIO(common_utils.TorchaudioTestCase):
......
......@@ -17,7 +17,7 @@ if LIBROSA_AVAILABLE:
import pytest
from . import common_utils
from torchaudio_unittest import common_utils
@unittest.skipIf(not LIBROSA_AVAILABLE, "Librosa not available")
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment