Simplify and abstract away asset access in test (#542)
This PR aims the following things; 1. Introduce and adopt helper function `get_asset_path` that abstract the logic to construct path to test assets. 2. Remove `create_temp_assets_dir` anywhere except `test_io`. The benefits of doing so are, a. the test code becomes simpler (no manual construction of asset path with `os.path.join`) b. No unnecessary directory creation and file copies. For 2. and b. tests in `test_io.py` (or tests that use `torchaudio.save`) are the only tests that need to write file to the disc, where the use of temporary directory makes it cleaner, therefore, `create_temp_assets_dir` is not necessary elsewhere. (still, `test_io` does not need to copy the entire asset directory, but that's not the point here.) Also if any test is accidentally overwriting an asset data, not using a copy will make us aware of such behavior, so it is better to get rid of `create_temp_assets_dir`.
Showing
Please register or sign in to comment