• Caroline Chen's avatar
    Rename resampling_method options (#2922) · e6bebe6a
    Caroline Chen authored
    Summary:
    resolves https://github.com/pytorch/audio/issues/2891
    
    Rename `resampling_method` options to more accurately describe what is happening. Previously the methods were set to `sinc_interpolation` and `kaiser_window`, which can be confusing as both options actually use sinc interpolation methodology, but differ in the window function used. As a result, rename `sinc_interpolation` to `sinc_interp_hann` and `kaiser_window` to `sinc_interp_kaiser`. Using an old option will throw a warning, and those options will be deprecated in 2 released. The numerical behavior is unchanged.
    
    Pull Request resolved: https://github.com/pytorch/audio/pull/2922
    
    Reviewed By: mthrok
    
    Differential Revision: D42083619
    
    Pulled By: carolineechen
    
    fbshipit-source-id: 9a9a7ea2d2daeadc02d53dddfd26afe249459e70
    e6bebe6a
audio_resampling_tutorial.py 17.1 KB