• bshall's avatar
    An implemenation of the ITU-R BS.1770-4 loudness recommendation (#2472) · 946b180a
    bshall authored
    Summary:
    I took a stab at implementing the ITU-R BS.1770-4 loudness recommendation (closes https://github.com/pytorch/audio/issues/1205). To give some more details:
    - I've implemented K-weighting following csteinmetz1 instead of BrechtDeMan since it fit well with torchaudio's already implemented filters (`treble_biquad` and `highpass_biquad`).
    - I've added four audio files to test compliance with the recommendation. These are linked in [this pdf](https://www.itu.int/dms_pub/itu-r/opb/rep/R-REP-BS.2217-2-2016-PDF-E.pdf). There are many more test files there but I didn't want to bog down the assets directory with too many files. Let me know if I should add or remove anything.
    - I've kept many of the constant internal to the function (e.g. the block duration, overlap, and the absolute threshold gamma). I'm not sure if these should be exposed in the signature.
    - I've implemented support for up to 5 channels (following both csteinmetz1 and BrechtDeMan). The recommendation includes weights for up to 24 channels. Is there any convention for how many channels to support?
    
    I hope this is helpful! looking forward to hearing from you.
    
    Pull Request resolved: https://github.com/pytorch/audio/pull/2472
    
    Reviewed By: hwangjeff
    
    Differential Revision: D38389155
    
    Pulled By: carolineechen
    
    fbshipit-source-id: fcc86d864c04ab2bedaa9acd941ebc4478ca6904
    946b180a
functional.rst 3.73 KB