Commit 28fce4cd authored by rusty1s's avatar rusty1s
Browse files

use in-place exp() + remove eps

parent 6a1525b5
...@@ -4,8 +4,8 @@ from torch_scatter import scatter_sum, scatter_max ...@@ -4,8 +4,8 @@ from torch_scatter import scatter_sum, scatter_max
from torch_scatter.utils import broadcast from torch_scatter.utils import broadcast
def scatter_softmax(src: torch.Tensor, index: torch.Tensor, dim: int = -1, def scatter_softmax(src: torch.Tensor, index: torch.Tensor,
eps: float = 1e-12) -> torch.Tensor: dim: int = -1) -> torch.Tensor:
if not torch.is_floating_point(src): if not torch.is_floating_point(src):
raise ValueError('`scatter_softmax` can only be computed over tensors ' raise ValueError('`scatter_softmax` can only be computed over tensors '
'with floating point data types.') 'with floating point data types.')
...@@ -16,10 +16,10 @@ def scatter_softmax(src: torch.Tensor, index: torch.Tensor, dim: int = -1, ...@@ -16,10 +16,10 @@ def scatter_softmax(src: torch.Tensor, index: torch.Tensor, dim: int = -1,
max_per_src_element = max_value_per_index.gather(dim, index) max_per_src_element = max_value_per_index.gather(dim, index)
recentered_scores = src - max_per_src_element recentered_scores = src - max_per_src_element
recentered_scores_exp = recentered_scores.exp() recentered_scores_exp = recentered_scores.exp_()
sum_per_index = scatter_sum(recentered_scores_exp, index, dim) sum_per_index = scatter_sum(recentered_scores_exp, index, dim)
normalizing_constants = sum_per_index.add_(eps).gather(dim, index) normalizing_constants = sum_per_index.gather(dim, index)
return recentered_scores_exp.div(normalizing_constants) return recentered_scores_exp.div(normalizing_constants)
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment