fix: metrics unbounded memory (#2528)

86984e32 · OlivierDehaene · GitHub · 71e42686 · 86984e32
Unverified Commit 86984e32 authored Sep 17, 2024 by OlivierDehaene Committed by GitHub Sep 17, 2024
Hide whitespace changes
Inline Side-by-side

Showing with 6 additions and 3 deletions

router/src/server.rs router/src/server.rs +6 -3

No files found.
--- a/router/src/server.rs
+++ b/router/src/server.rs
@@ -2136,9 +2136,12 @@ async fn start(
        .unwrap();
    // .set_buckets_for_metric(skipped_matcher, &skipped_buckets)
    // .unwrap();
-    let prom_handle = builder
+    // See: https://github.com/metrics-rs/metrics/issues/467#issuecomment-2022755151
-        .install_recorder()
+    let (recorder, _) = builder
-        .expect("failed to install metrics recorder");
+        .build()
+        .expect("failed to build prometheus recorder");
+    let prom_handle = recorder.handle();
+    metrics::set_global_recorder(recorder).expect("Failed to set global recorder");
    // Metrics descriptions
    metrics::describe_counter!("tgi_request_success", "Number of successful requests");