Unverified Commit 529d7c25 authored by Nicolas Patry's avatar Nicolas Patry Committed by GitHub
Browse files

Fix local load for peft (#1373)

local directory overloaded still needs the directory to locate the
weights files correctly.

# What does this PR do?

<!--
Congratulations! You've made it this far! You're not quite done yet
though.

Once merged, your PR is going to appear in the release notes with the
title you set, so make sure it's a great title that fully reflects the
extent of your awesome contribution.

Then, please replace this with a description of the change and which
issue is fixed (if applicable). Please also include relevant motivation
and context. List any dependencies (if any) that are required for this
change.

Once you're done, someone will review your PR shortly (see the section
"Who can review?" below to tag some potential reviewers). They may
suggest changes to make the code even better. If no one reviewed your PR
after a week has passed, don't hesitate to post a new comment
@-mentioning the same persons---sometimes notifications get lost.
-->

<!-- Remove if not applicable -->

Fixes # (issue)


## Before submitting
- [ ] This PR fixes a typo or improves the docs (you can dismiss the
other checks if that's the case).
- [ ] Did you read the [contributor
guideline](https://github.com/huggingface/transformers/blob/main/CONTRIBUTING.md#start-contributing-pull-requests),
      Pull Request section?
- [ ] Was this discussed/approved via a Github issue or the
[forum](https://discuss.huggingface.co/)? Please add a link
      to it if that's the case.
- [ ] Did you make sure to update the documentation with your changes?
Here are the
[documentation
guidelines](https://github.com/huggingface/transformers/tree/main/docs),
and
[here are tips on formatting
docstrings](https://github.com/huggingface/transformers/tree/main/docs#writing-source-documentation).
- [ ] Did you write any new necessary tests?


## Who can review?

Anyone in the community is free to review the PR once the tests have
passed. Feel free to tag
members/contributors who may be interested in your PR.

<!-- Your PR will be replied to more quickly if you can figure out the
right person to tag with @


@OlivierDehaene OR @Narsil

 -->
parent 564199ba
...@@ -61,7 +61,15 @@ def test_weight_hub_files_offline_error(offline, fresh_cache): ...@@ -61,7 +61,15 @@ def test_weight_hub_files_offline_error(offline, fresh_cache):
def test_weight_hub_files_offline_ok(prefetched, offline): def test_weight_hub_files_offline_ok(prefetched, offline):
# If the model is prefetched then we should be able to get the weight files from local cache # If the model is prefetched then we should be able to get the weight files from local cache
filenames = weight_hub_files(prefetched) filenames = weight_hub_files(prefetched)
assert filenames == ["model.safetensors"] root = None
assert len(filenames) == 1
for f in filenames:
curroot, filename = os.path.split(f)
if root is None:
root = curroot
else:
assert root == curroot
assert filename == "model.safetensors"
def test_weight_hub_files(): def test_weight_hub_files():
......
...@@ -49,7 +49,7 @@ def _weight_files_from_dir(d: Path, extension: str) -> List[str]: ...@@ -49,7 +49,7 @@ def _weight_files_from_dir(d: Path, extension: str) -> List[str]:
# done there with the len(s.rfilename.split("/")) == 1 condition # done there with the len(s.rfilename.split("/")) == 1 condition
root, _, files = next(os.walk(str(d))) root, _, files = next(os.walk(str(d)))
filenames = [ filenames = [
f os.path.join(root, f)
for f in files for f in files
if f.endswith(extension) if f.endswith(extension)
and "arguments" not in f and "arguments" not in f
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment