• Nicolas Patry's avatar
    feat(server): Add native support for PEFT Lora models (#762) · ac736fd8
    Nicolas Patry authored
    - Will detect `peft` model by finding `adapter_config.json`.
    - This triggers a totally dedicated `download-weights` path
    - This path, loads the adapter config, finds the base model_id
    - It loads the base_model
    - Then peft_model
    - Then `merge_and_unload()`
    - Then `save_pretrained(.., safe_serialization=True)
    - Add back the config + tokenizer.merge_and_unload()`
    - Then `save_pretrained(.., safe_serialization=True)
    - Add back the config + tokenizer.
    - The chosen location is a **local folder with the name of the user
      chosen model id**
    
    PROs:
    
    - Easier than to expect user to merge manually
    - Barely any change outside of `download-weights` command.
    - This means everything will work in a single load.
    - Should enable out of the box SM + HFE
    
    CONs:
    
    - Creates a local merged model in unusual location, potentially
      not saved across docker reloads, or ovewriting some files if the PEFT
      itself was local and containing other files in addition to the lora
    
    Alternatives considered:
    - Add `local_files_only=True` every where (discard because of massive
      code change for not a good enough reason)
    - Return something to `launcher` about the new model-id (a cleaner
      location for this new model), but it would
      introduce new communication somewhere where we didn't need it before.
    - Using the HF cache folder and *stopping* the flow after
      `download-weights` and asking user to restart with the actual local
      model location
    
    
    Fix #482 
    
    
    # What does this PR do?
    
    <!--
    Congratulations! You've made it this far! You're not quite done yet
    though.
    
    Once merged, your PR is going to appear in the release notes with the
    title you set, so make sure it's a great title that fully reflects the
    extent of your awesome contribution.
    
    Then, please replace this with a description of the change and which
    issue is fixed (if applicable). Please also include relevant motivation
    and context. List any dependencies (if any) that are required for this
    change.
    
    Once you're done, someone will review your PR shortly (see the section
    "Who can review?" below to tag some potential reviewers). They may
    suggest changes to make the code even better. If no one reviewed your PR
    after a week has passed, don't hesitate to post a new comment
    @-mentioning the same persons---sometimes notifications get lost.
    -->
    
    <!-- Remove if not applicable -->
    
    Fixes # (issue)
    
    
    ## Before submitting
    - [ ] This PR fixes a typo or improves the docs (you can dismiss the
    other checks if that's the case).
    - [ ] Did you read the [contributor
    guideline](https://github.com/huggingface/transformers/blob/main/CONTRIBUTING.md#start-contributing-pull-requests),
          Pull Request section?
    - [ ] Was this discussed/approved via a Github issue or the
    [forum](https://discuss.huggingface.co/)? Please add a link
          to it if that's the case.
    - [ ] Did you make sure to update the documentation with your changes?
    Here are the
    [documentation
    guidelines](https://github.com/huggingface/transformers/tree/main/docs),
    and
    [here are tips on formatting
    docstrings](https://github.com/huggingface/transformers/tree/main/docs#writing-source-documentation).
    - [ ] Did you write any new necessary tests?
    
    
    ## Who can review?
    
    Anyone in the community is free to review the PR once the tests have
    passed. Feel free to tag
    members/contributors who may be interested in your PR.
    
    <!-- Your PR will be replied to more quickly if you can figure out the
    right person to tag with @
    
    
    @OlivierDehaene OR @Narsil
    
     -->
    ac736fd8
pyproject.toml 1.37 KB