• Nicolas Patry's avatar
    feat(server): Using `quantize_config.json` instead of GPTQ_BITS env variables. (#671) · a0d55358
    Nicolas Patry authored
    - Current PR is not great because we're side stepping the
      `Weights.__init__` but Weights shouldn't requires anything related
      to the config or the model_id as it aims to be a simple Wrapper
      over multi file loading.
    - Ideal solution would be to use something like Rust enum
      ```
      enum Quantize{
        Bitandbytes(Bitsandbytes),
        GPTQ(bits: usize, groupsize: usize)
      ```
      And passing that around during load. Unfortunately we don't
      have access to this, so for now, side-stepping seems easier.
    
    - Re-enabling groupsize<0 with exllama (confirmed it works.)
    
    Helps #601 
    
    In next steps we should make sure our quantization script uses that
    format and make it standard.
    
    
    # What does this PR do?
    
    <!--
    Congratulations! You've made it this far! You're not quite done yet
    though.
    
    Once merged, your PR is going to appear in the release notes with the
    title you set, so make sure it's a great title that fully reflects the
    extent of your awesome contribution.
    
    Then, please replace this with a description of the change and which
    issue is fixed (if applicable). Please also include relevant motivation
    and context. List any dependencies (if any) that are required for this
    change.
    
    Once you're done, someone will review your PR shortly (see the section
    "Who can review?" below to tag some potential reviewers). They may
    suggest changes to make the code even better. If no one reviewed your PR
    after a week has passed, don't hesitate to post a new comment
    @-mentioning the same persons---sometimes notifications get lost.
    -->
    
    <!-- Remove if not applicable -->
    
    Fixes # (issue)
    
    
    ## Before submitting
    - [ ] This PR fixes a typo or improves the docs (you can dismiss the
    other checks if that's the case).
    - [ ] Did you read the [contributor
    guideline](https://github.com/huggingface/transformers/blob/main/CONTRIBUTING.md#start-contributing-pull-requests),
          Pull Request section?
    - [ ] Was this discussed/approved via a Github issue or the
    [forum](https://discuss.huggingface.co/)? Please add a link
          to it if that's the case.
    - [ ] Did you make sure to update the documentation with your changes?
    Here are the
    [documentation
    guidelines](https://github.com/huggingface/transformers/tree/main/docs),
    and
    [here are tips on formatting
    docstrings](https://github.com/huggingface/transformers/tree/main/docs#writing-source-documentation).
    - [ ] Did you write any new necessary tests?
    
    
    ## Who can review?
    
    Anyone in the community is free to review the PR once the tests have
    passed. Feel free to tag
    members/contributors who may be interested in your PR.
    
    <!-- Your PR will be replied to more quickly if you can figure out the
    right person to tag with @
    
    
    @OlivierDehaene OR @Narsil
    
     -->
    a0d55358
gpt_neox.py 2.54 KB