validation.rs 23.5 KB
Newer Older
Olivier Dehaene's avatar
v0.1.0  
Olivier Dehaene committed
1
/// Payload validation logic
2
use crate::validation::ValidationError::{BestOfSampling, BestOfSeed, EmptyInput};
drbh's avatar
drbh committed
3
use crate::{GenerateParameters, GenerateRequest, GrammarType};
4
use rand::{thread_rng, Rng};
drbh's avatar
drbh committed
5
6
7
use text_generation_client::{
    GrammarType as ProtoGrammarType, NextTokenChooserParameters, StoppingCriteriaParameters,
};
Olivier Dehaene's avatar
Olivier Dehaene committed
8
use thiserror::Error;
Olivier Dehaene's avatar
Olivier Dehaene committed
9
use tokenizers::tokenizer::Tokenizer;
10
use tokenizers::TruncationDirection;
OlivierDehaene's avatar
OlivierDehaene committed
11
use tokio::sync::mpsc;
12
use tokio::sync::oneshot;
13
use tracing::{instrument, Span};
Olivier Dehaene's avatar
Olivier Dehaene committed
14

Olivier Dehaene's avatar
v0.1.0  
Olivier Dehaene committed
15
/// Validation
Olivier Dehaene's avatar
Olivier Dehaene committed
16
#[derive(Debug, Clone)]
Olivier Dehaene's avatar
Olivier Dehaene committed
17
pub struct Validation {
18
    /// Validation parameters
19
    max_best_of: usize,
20
    max_stop_sequences: usize,
Nicolas Patry's avatar
Nicolas Patry committed
21
    max_top_n_tokens: u32,
22
23
    max_input_length: usize,
    max_total_tokens: usize,
drbh's avatar
drbh committed
24
    disable_grammar_support: bool,
25
    /// Channel to communicate with the background tokenization task
OlivierDehaene's avatar
OlivierDehaene committed
26
    sender: Option<mpsc::UnboundedSender<TokenizerRequest>>,
Olivier Dehaene's avatar
Olivier Dehaene committed
27
28
29
}

impl Validation {
30
31
    pub(crate) fn new(
        workers: usize,
32
        tokenizer: Option<Tokenizer>,
33
        max_best_of: usize,
34
        max_stop_sequences: usize,
Nicolas Patry's avatar
Nicolas Patry committed
35
        max_top_n_tokens: u32,
36
37
        max_input_length: usize,
        max_total_tokens: usize,
drbh's avatar
drbh committed
38
        disable_grammar_support: bool,
39
    ) -> Self {
40
41
        // If we have a fast tokenizer
        let sender = if let Some(tokenizer) = tokenizer {
OlivierDehaene's avatar
OlivierDehaene committed
42
43
44
            // Create round robin channel
            let (validation_sender, validation_round_robin_receiver) = mpsc::unbounded_channel();
            let mut senders = Vec::with_capacity(workers);
45
46
47
48

            // Create workers
            for _ in 0..workers {
                let tokenizer_clone = tokenizer.clone();
OlivierDehaene's avatar
OlivierDehaene committed
49
50
                let (tokenizer_sender, tokenizer_receiver) = mpsc::unbounded_channel();
                senders.push(tokenizer_sender);
51
52
53

                // Spawn worker
                tokio::task::spawn_blocking(move || {
OlivierDehaene's avatar
OlivierDehaene committed
54
                    tokenizer_worker(tokenizer_clone, tokenizer_receiver)
55
56
                });
            }
OlivierDehaene's avatar
OlivierDehaene committed
57
58
59
60

            // Create tokenization round robin task
            tokio::spawn(round_robin_task(validation_round_robin_receiver, senders));

61
62
63
64
65
66
67
68
            Some(validation_sender)
        } else {
            None
        };

        Self {
            max_best_of,
            sender,
69
            max_stop_sequences,
Nicolas Patry's avatar
Nicolas Patry committed
70
            max_top_n_tokens,
Olivier Dehaene's avatar
v0.1.0  
Olivier Dehaene committed
71
            max_input_length,
72
            max_total_tokens,
drbh's avatar
drbh committed
73
            disable_grammar_support,
74
75
        }
    }
Olivier Dehaene's avatar
Olivier Dehaene committed
76

77
    #[instrument(skip(self, inputs))]
78
    pub async fn tokenize(
79
80
81
        &self,
        inputs: String,
        truncate: Option<usize>,
82
    ) -> Result<Option<(tokenizers::Encoding, String)>, ValidationError> {
83
84
85
86
87
88
89
90
91
92
93
94
        // If we have a fast tokenizer
        if let Some(sender) = &self.sender {
            // Create response channel
            let (response_sender, response_receiver) = oneshot::channel();
            // Send request to the background validation task
            // Unwrap is safe here
            sender
                .send(((inputs, truncate), response_sender, Span::current()))
                .unwrap();

            // Await on response channel
            // Unwrap is safe here
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
            let encoding = response_receiver.await.unwrap()?;
            Ok(Some(encoding))
        } else {
            Ok(None)
        }
    }

    #[instrument(skip(self, inputs))]
    async fn validate_input(
        &self,
        inputs: String,
        truncate: Option<usize>,
        max_new_tokens: Option<u32>,
    ) -> Result<(String, usize, u32), ValidationError> {
        // If we have a fast tokenizer
        if let Some((encoding, inputs)) = self.tokenize(inputs.clone(), truncate).await? {
            // Create response channel
            let input_length = encoding.len();
113
114

            // Get total tokens
115
116
117
118
119
            let max_new_tokens: u32 = if let Some(max_new_tokens) = max_new_tokens {
                max_new_tokens
            } else {
                self.max_total_tokens.saturating_sub(input_length) as u32
            };
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
            let total_tokens = input_length + max_new_tokens as usize;

            // Validate MaxTotalTokens
            if total_tokens > self.max_total_tokens {
                return Err(ValidationError::MaxTotalTokens(
                    self.max_total_tokens,
                    input_length,
                    max_new_tokens,
                ));
            }

            // Validate InputLength
            if input_length > self.max_input_length {
                return Err(ValidationError::InputLength(
                    self.max_input_length,
                    input_length,
                ));
            }

            metrics::histogram!("tgi_request_input_length", input_length as f64);
140
            Ok((inputs, input_length, max_new_tokens))
141
142
143
144
145
146
        }
        // Return inputs without validation
        else {
            // In this case, we don't know the real length in tokens of the inputs
            // However, the inputs will be truncated by the python servers
            // We make sure that truncate + max_new_tokens <= self.max_total_tokens
147
148
            let max_new_tokens: u32 = if let Some(max_new_tokens) = max_new_tokens {
                max_new_tokens
OlivierDehaene's avatar
OlivierDehaene committed
149
150
            } else if let Some(truncate) = truncate {
                self.max_total_tokens.saturating_sub(truncate) as u32
151
            } else {
OlivierDehaene's avatar
OlivierDehaene committed
152
                return Err(ValidationError::UnsetMaxNewTokens);
153
            };
154
            let input_length = truncate.unwrap_or(self.max_input_length);
155
156

            // Validate MaxNewTokens
157
            if (input_length as u32 + max_new_tokens) > self.max_total_tokens as u32 {
158
159
160
161
162
163
                return Err(ValidationError::MaxNewTokens(
                    self.max_total_tokens - self.max_input_length,
                    max_new_tokens,
                ));
            }

164
            Ok((inputs, input_length, max_new_tokens))
Olivier Dehaene's avatar
Olivier Dehaene committed
165
166
167
        }
    }

Olivier Dehaene's avatar
v0.1.0  
Olivier Dehaene committed
168
    /// Validate a payload and get the number of tokens in the input
169
    #[instrument(skip_all)]
Olivier Dehaene's avatar
Olivier Dehaene committed
170
171
172
    pub(crate) async fn validate(
        &self,
        request: GenerateRequest,
173
    ) -> Result<ValidGenerateRequest, ValidationError> {
174
175
176
177
        let GenerateParameters {
            best_of,
            temperature,
            repetition_penalty,
178
            frequency_penalty,
179
180
181
182
183
184
185
186
187
            top_k,
            top_p,
            typical_p,
            do_sample,
            max_new_tokens,
            stop: stop_sequences,
            truncate,
            seed,
            watermark,
188
            decoder_input_details,
Nicolas Patry's avatar
Nicolas Patry committed
189
            top_n_tokens,
drbh's avatar
drbh committed
190
            grammar,
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
            ..
        } = request.parameters;

        // sampling must be true when best_of > 1
        let best_of = best_of.unwrap_or(1);
        let sampling = do_sample
            || temperature.is_some()
            || top_k.is_some()
            || top_p.is_some()
            || typical_p.is_some();

        if best_of > 1 && !sampling {
            return Err(BestOfSampling);
        }

        let temperature = temperature.unwrap_or(1.0);
        if temperature <= 0.0 {
            return Err(ValidationError::Temperature);
        }

        let repetition_penalty = repetition_penalty.unwrap_or(1.0);
        if repetition_penalty <= 0.0 {
            return Err(ValidationError::RepetitionPenalty);
        }

216
217
218
219
220
        let frequency_penalty = frequency_penalty.unwrap_or(0.0);
        if !(-2.0..=2.0).contains(&frequency_penalty) {
            return Err(ValidationError::FrequencyPenalty);
        }

221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
        // Different because the proto default value is not a valid value
        // for the user
        let top_p = top_p
            .map(|value| {
                if value <= 0.0 || value >= 1.0 {
                    return Err(ValidationError::TopP);
                }
                Ok(value)
            })
            .unwrap_or(Ok(1.0))?;

        let typical_p = typical_p
            .map(|value| {
                if value <= 0.0 || value >= 1.0 {
                    return Err(ValidationError::TypicalP);
                }
                Ok(value)
            })
            .unwrap_or(Ok(1.0))?;

        let top_k: u32 = top_k
            .map(|value| {
                if value <= 0 {
                    return Err(ValidationError::TopK);
                }
                Ok(value as u32)
            })
            .unwrap_or(Ok(0))?;

250
        if max_new_tokens == Some(0) {
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
            return Err(ValidationError::NegativeMaxNewTokens);
        }

        if stop_sequences.len() > self.max_stop_sequences {
            return Err(ValidationError::StopSequence(
                self.max_stop_sequences,
                stop_sequences.len(),
            ));
        }

        // If seed is None, assign a random one
        let seed = match seed {
            None => thread_rng().gen(),
            Some(seed) => {
                if best_of > 1 {
                    return Err(BestOfSeed);
                }
                seed
            }
        };

Nicolas Patry's avatar
Nicolas Patry committed
272
273
274
275
276
277
278
279
280
        let top_n_tokens = top_n_tokens
            .map(|value| {
                if value > self.max_top_n_tokens {
                    return Err(ValidationError::TopNTokens(self.max_top_n_tokens, value));
                }
                Ok(value)
            })
            .unwrap_or(Ok(0))?;

281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
        // Check if inputs is empty
        if request.inputs.is_empty() {
            return Err(EmptyInput);
        }

        // Check if truncate is strictly positive and less than max_input_length
        let truncate = truncate
            .map(|value| {
                if value == 0 || value > self.max_input_length {
                    return Err(ValidationError::Truncate(self.max_input_length, value));
                }
                Ok(Some(value))
            })
            .unwrap_or(Ok(None))?;

        // Validate inputs
297
        let (inputs, input_length, max_new_tokens) = self
298
299
300
            .validate_input(request.inputs, truncate, max_new_tokens)
            .await?;

drbh's avatar
drbh committed
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
        // TODO: we should build the FSM here and pass the compiled FSM instead of the grammar
        // NOTE: this is currently difficult because we need the tokenizer in Python to build
        // the FSM and we'd have to load a copy of the tokenizer into our Pyo3 instance which
        // may be slow and memory intensive. Best case is to have a Rust implementation of the FSM
        // compiler and use that to build the FSM here.

        // Validate grammar and unpack the grammar and type for the proto message
        let (grammar, grammar_type) = match grammar {
            Some(grammar) => {
                // Ensure that grammar is not set if it's not supported
                if self.disable_grammar_support {
                    return Err(ValidationError::Grammar);
                }
                match grammar {
                    // currently both are handled the same way since compilation is done in Python
                    GrammarType::Json(json) => (json, ProtoGrammarType::Json.into()),
                    GrammarType::Regex(regex) => (regex, ProtoGrammarType::Regex.into()),
                }
            }
            None => (String::new(), ProtoGrammarType::None.into()),
        };

323
324
325
        let parameters = NextTokenChooserParameters {
            temperature,
            repetition_penalty,
326
            frequency_penalty,
327
328
329
330
331
332
            top_k,
            top_p,
            typical_p,
            do_sample,
            seed,
            watermark,
drbh's avatar
drbh committed
333
334
            grammar,
            grammar_type,
335
336
337
338
339
340
341
342
343
344
345
        };
        let stopping_parameters = StoppingCriteriaParameters {
            max_new_tokens,
            stop_sequences,
            ignore_eos_token: false,
        };

        metrics::histogram!("tgi_request_max_new_tokens", max_new_tokens as f64);

        Ok(ValidGenerateRequest {
            inputs,
346
            decoder_input_details,
347
            input_length: input_length as u32,
348
349
350
            truncate: truncate.unwrap_or(self.max_input_length) as u32,
            parameters,
            stopping_parameters,
Nicolas Patry's avatar
Nicolas Patry committed
351
            top_n_tokens,
352
        })
Olivier Dehaene's avatar
Olivier Dehaene committed
353
    }
354
355
356
357
358
359
360
361
362
363
364
365
366
367

    /// Validate the best_of parameter
    #[instrument(skip_all)]
    pub(crate) fn validate_best_of(&self, best_of: usize) -> Result<usize, ValidationError> {
        if self.max_best_of == 1 && best_of != 1 {
            return Err(ValidationError::BestOfDisabled);
        }

        if best_of > self.max_best_of {
            return Err(ValidationError::BestOf(self.max_best_of, best_of));
        }

        Ok(best_of)
    }
Olivier Dehaene's avatar
Olivier Dehaene committed
368
369
}

OlivierDehaene's avatar
OlivierDehaene committed
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
/// Round robin tokenization task
async fn round_robin_task(
    mut receiver: mpsc::UnboundedReceiver<TokenizerRequest>,
    senders: Vec<mpsc::UnboundedSender<TokenizerRequest>>,
) {
    loop {
        for sender in &senders {
            match receiver.recv().await {
                None => return,
                Some(request) => sender.send(request).unwrap(),
            };
        }
    }
}

385
/// Start tokenization workers
OlivierDehaene's avatar
OlivierDehaene committed
386
fn tokenizer_worker(tokenizer: Tokenizer, mut receiver: mpsc::UnboundedReceiver<TokenizerRequest>) {
Olivier Dehaene's avatar
v0.1.0  
Olivier Dehaene committed
387
    // Loop over requests
OlivierDehaene's avatar
OlivierDehaene committed
388
    while let Some(((inputs, truncate), response_tx, parent_span)) = receiver.blocking_recv() {
389
390
        parent_span.in_scope(|| {
            response_tx
391
                .send(prepare_input(inputs, truncate, &tokenizer))
392
393
                .unwrap_or(())
        })
394
395
    }
}
Olivier Dehaene's avatar
Olivier Dehaene committed
396

397
398
/// Get input length and optionally truncate it
fn prepare_input(
399
    mut inputs: String,
400
    truncate: Option<usize>,
401
    tokenizer: &Tokenizer,
402
) -> Result<(tokenizers::Encoding, String), ValidationError> {
403
404
    // Get the number of tokens in the input
    let mut encoding = tokenizer
405
        .encode(inputs.clone(), true)
406
407
        .map_err(|err| ValidationError::Tokenizer(err.to_string()))?;

408
    // Optionally truncate
409
410
    if let Some(truncate) = truncate {
        if truncate < encoding.len() {
411
            encoding.truncate(truncate, 0, TruncationDirection::Left);
412
            inputs = tokenizer
413
                .decode(encoding.get_ids(), false)
414
415
                .map_err(|err| ValidationError::Tokenizer(err.to_string()))?;
        }
416
    }
417

418
    Ok((encoding, inputs))
Olivier Dehaene's avatar
Olivier Dehaene committed
419
}
Olivier Dehaene's avatar
v0.1.0  
Olivier Dehaene committed
420

421
422
type TokenizerRequest = (
    (String, Option<usize>),
423
    oneshot::Sender<Result<(tokenizers::Encoding, String), ValidationError>>,
424
    Span,
Olivier Dehaene's avatar
v0.1.0  
Olivier Dehaene committed
425
426
);

427
#[derive(Debug, Clone)]
428
429
pub(crate) struct ValidGenerateRequest {
    pub inputs: String,
430
    pub input_length: u32,
431
    pub truncate: u32,
432
    pub decoder_input_details: bool,
433
434
    pub parameters: NextTokenChooserParameters,
    pub stopping_parameters: StoppingCriteriaParameters,
Nicolas Patry's avatar
Nicolas Patry committed
435
    pub top_n_tokens: u32,
436
437
}

Olivier Dehaene's avatar
v0.1.0  
Olivier Dehaene committed
438
439
#[derive(Error, Debug)]
pub enum ValidationError {
440
441
442
443
444
445
446
447
448
449
    #[error("`best_of` must be > 0 and <= {0}. Given: {1}")]
    BestOf(usize, usize),
    #[error("`best_of` != 1 is not allowed for this endpoint")]
    BestOfDisabled,
    #[error("you must use sampling when `best_of` is > 1")]
    BestOfSampling,
    #[error("`seed` must not be set when `best_of` > 1")]
    BestOfSeed,
    #[error("`best_of` != 1 is not supported when streaming tokens")]
    BestOfStream,
Nicolas Patry's avatar
Nicolas Patry committed
450
451
452
453
    #[error("`top_n_tokens` must be >= 0 and <= {0}. Given: {1}")]
    TopNTokens(u32, u32),
    #[error("`top_n_tokens` != 0 is not allowed for this endpoint")]
    TopNTokensDisabled,
454
455
    #[error("`decoder_input_details` == true is not supported when streaming tokens")]
    PrefillDetailsStream,
456
    #[error("`temperature` must be strictly positive")]
Olivier Dehaene's avatar
v0.1.0  
Olivier Dehaene committed
457
    Temperature,
458
    #[error("`repetition_penalty` must be strictly positive")]
459
    RepetitionPenalty,
460
461
    #[error("`frequency_penalty` must be >= -2.0 and <= 2.0")]
    FrequencyPenalty,
462
    #[error("`top_p` must be > 0.0 and < 1.0")]
Olivier Dehaene's avatar
v0.1.0  
Olivier Dehaene committed
463
    TopP,
464
    #[error("`top_k` must be strictly positive")]
Olivier Dehaene's avatar
v0.1.0  
Olivier Dehaene committed
465
    TopK,
466
467
    #[error("`truncate` must be strictly positive and less than {0}. Given: {1}")]
    Truncate(usize, usize),
468
469
    #[error("`typical_p` must be > 0.0 and < 1.0")]
    TypicalP,
470
471
    #[error("one of `max_new_tokens` or `truncate` must be set if a fast tokenizer is not in use")]
    UnsetMaxNewTokens,
472
    #[error("`max_new_tokens` must be strictly positive")]
473
474
475
    NegativeMaxNewTokens,
    #[error("`max_new_tokens` must be <= {0}. Given: {1}")]
    MaxNewTokens(usize, u32),
476
    #[error("`inputs` tokens + `max_new_tokens` must be <= {0}. Given: {1} `inputs` tokens and {2} `max_new_tokens`")]
477
    MaxTotalTokens(usize, usize, u32),
478
    #[error("`inputs` must have less than {0} tokens. Given: {1}")]
479
    InputLength(usize, usize),
480
    #[error("`inputs` cannot be empty")]
481
    EmptyInput,
482
    #[error("`stop` supports up to {0} stop sequences. Given: {1}")]
483
    StopSequence(usize, usize),
484
485
    #[error("tokenizer error {0}")]
    Tokenizer(String),
drbh's avatar
drbh committed
486
487
    #[error("grammar is not supported")]
    Grammar,
Olivier Dehaene's avatar
v0.1.0  
Olivier Dehaene committed
488
}
489
490

#[cfg(test)]
491
mod tests {
492
    use super::*;
493
494
    use crate::default_parameters;
    use crate::tests::get_tokenizer;
495
496

    #[tokio::test]
497
    async fn test_validation_max_new_tokens() {
498
499
500
        let tokenizer = None;
        let max_best_of = 2;
        let max_stop_sequence = 3;
Nicolas Patry's avatar
Nicolas Patry committed
501
502
503
        let max_top_n_tokens = 4;
        let max_input_length = 5;
        let max_total_tokens = 6;
504
        let workers = 1;
drbh's avatar
drbh committed
505
        let disable_grammar_support = true;
506
507
508
509
510
        let validation = Validation::new(
            workers,
            tokenizer,
            max_best_of,
            max_stop_sequence,
Nicolas Patry's avatar
Nicolas Patry committed
511
            max_top_n_tokens,
512
513
            max_input_length,
            max_total_tokens,
drbh's avatar
drbh committed
514
            disable_grammar_support,
515
        );
516
517

        let max_new_tokens = 10;
518
        match validation
519
            .validate_input("Hello".to_string(), None, Some(max_new_tokens))
520
521
            .await
        {
522
            Err(ValidationError::MaxNewTokens(1, 10)) => (),
523
            _ => panic!("Unexpected not max new tokens"),
524
525
526
527
        }
    }

    #[tokio::test]
528
    async fn test_validation_input_length() {
529
530
531
        let tokenizer = Some(get_tokenizer().await);
        let max_best_of = 2;
        let max_stop_sequence = 3;
Nicolas Patry's avatar
Nicolas Patry committed
532
533
534
        let max_top_n_tokens = 4;
        let max_input_length = 5;
        let max_total_tokens = 6;
drbh's avatar
drbh committed
535
        let disable_grammar_support = true;
536
        let workers = 1;
537
538
539
540
541
        let validation = Validation::new(
            workers,
            tokenizer,
            max_best_of,
            max_stop_sequence,
Nicolas Patry's avatar
Nicolas Patry committed
542
            max_top_n_tokens,
543
544
            max_input_length,
            max_total_tokens,
drbh's avatar
drbh committed
545
            disable_grammar_support,
546
        );
547
548

        let max_new_tokens = 10;
549
        match validation
550
            .validate_input("Hello".to_string(), None, Some(max_new_tokens))
551
552
            .await
        {
Nicolas Patry's avatar
Nicolas Patry committed
553
            Err(ValidationError::MaxTotalTokens(6, 1, 10)) => (),
554
            _ => panic!("Unexpected not max new tokens"),
555
556
        }
    }
557
558

    #[tokio::test]
559
    async fn test_validation_best_of_sampling() {
560
561
562
        let tokenizer = Some(get_tokenizer().await);
        let max_best_of = 2;
        let max_stop_sequence = 3;
Nicolas Patry's avatar
Nicolas Patry committed
563
564
565
        let max_top_n_tokens = 4;
        let max_input_length = 5;
        let max_total_tokens = 6;
566
        let workers = 1;
drbh's avatar
drbh committed
567
        let disable_grammar_support = true;
568
569
570
571
572
        let validation = Validation::new(
            workers,
            tokenizer,
            max_best_of,
            max_stop_sequence,
Nicolas Patry's avatar
Nicolas Patry committed
573
            max_top_n_tokens,
574
575
            max_input_length,
            max_total_tokens,
drbh's avatar
drbh committed
576
            disable_grammar_support,
577
578
579
580
581
582
583
584
585
586
587
588
        );
        match validation
            .validate(GenerateRequest {
                inputs: "Hello".to_string(),
                parameters: GenerateParameters {
                    best_of: Some(2),
                    do_sample: false,
                    ..default_parameters()
                },
            })
            .await
        {
589
            Err(ValidationError::BestOfSampling) => (),
590
            _ => panic!("Unexpected not best of sampling"),
591
592
593
594
        }
    }

    #[tokio::test]
595
    async fn test_validation_top_p() {
596
597
598
        let tokenizer = Some(get_tokenizer().await);
        let max_best_of = 2;
        let max_stop_sequence = 3;
Nicolas Patry's avatar
Nicolas Patry committed
599
600
        let max_top_n_tokens = 4;
        let max_input_length = 5;
601
        let max_total_tokens = 106;
602
        let workers = 1;
drbh's avatar
drbh committed
603
        let disable_grammar_support = true;
604
605
606
607
608
        let validation = Validation::new(
            workers,
            tokenizer,
            max_best_of,
            max_stop_sequence,
Nicolas Patry's avatar
Nicolas Patry committed
609
            max_top_n_tokens,
610
611
            max_input_length,
            max_total_tokens,
drbh's avatar
drbh committed
612
            disable_grammar_support,
613
614
615
616
617
618
        );
        match validation
            .validate(GenerateRequest {
                inputs: "Hello".to_string(),
                parameters: GenerateParameters {
                    top_p: Some(1.0),
619
                    max_new_tokens: Some(5),
620
621
622
623
624
                    ..default_parameters()
                },
            })
            .await
        {
625
            Err(ValidationError::TopP) => (),
626
            _ => panic!("Unexpected top_p"),
627
628
        }

629
630
631
632
633
        match validation
            .validate(GenerateRequest {
                inputs: "Hello".to_string(),
                parameters: GenerateParameters {
                    top_p: Some(0.99),
634
                    max_new_tokens: Some(5),
635
636
637
638
639
                    ..default_parameters()
                },
            })
            .await
        {
640
            Ok(_) => (),
641
            _ => panic!("Unexpected top_p error"),
642
643
        }

644
645
646
647
648
        let valid_request = validation
            .validate(GenerateRequest {
                inputs: "Hello".to_string(),
                parameters: GenerateParameters {
                    top_p: None,
649
                    max_new_tokens: Some(5),
650
651
652
653
654
                    ..default_parameters()
                },
            })
            .await
            .unwrap();
655
656
657
        // top_p == 1.0 is invalid for users to ask for but it's the default resolved value.
        assert_eq!(valid_request.parameters.top_p, 1.0);
    }
Nicolas Patry's avatar
Nicolas Patry committed
658
659
660
661
662
663
664
665

    #[tokio::test]
    async fn test_validation_top_n_tokens() {
        let tokenizer = Some(get_tokenizer().await);
        let max_best_of = 2;
        let max_stop_sequences = 3;
        let max_top_n_tokens = 4;
        let max_input_length = 5;
666
        let max_total_tokens = 106;
Nicolas Patry's avatar
Nicolas Patry committed
667
        let workers = 1;
drbh's avatar
drbh committed
668
        let disable_grammar_support = true;
Nicolas Patry's avatar
Nicolas Patry committed
669
670
671
672
673
674
675
676
        let validation = Validation::new(
            workers,
            tokenizer,
            max_best_of,
            max_stop_sequences,
            max_top_n_tokens,
            max_input_length,
            max_total_tokens,
drbh's avatar
drbh committed
677
            disable_grammar_support,
Nicolas Patry's avatar
Nicolas Patry committed
678
679
680
681
682
683
        );
        match validation
            .validate(GenerateRequest {
                inputs: "Hello".to_string(),
                parameters: GenerateParameters {
                    top_n_tokens: Some(5),
684
                    max_new_tokens: Some(5),
Nicolas Patry's avatar
Nicolas Patry committed
685
686
687
688
689
690
691
692
693
694
695
696
697
698
                    ..default_parameters()
                },
            })
            .await
        {
            Err(ValidationError::TopNTokens(4, 5)) => (),
            _ => panic!("Unexpected top_n_tokens"),
        }

        validation
            .validate(GenerateRequest {
                inputs: "Hello".to_string(),
                parameters: GenerateParameters {
                    top_n_tokens: Some(4),
699
                    max_new_tokens: Some(5),
Nicolas Patry's avatar
Nicolas Patry committed
700
701
702
703
704
705
706
707
708
709
710
                    ..default_parameters()
                },
            })
            .await
            .unwrap();

        validation
            .validate(GenerateRequest {
                inputs: "Hello".to_string(),
                parameters: GenerateParameters {
                    top_n_tokens: Some(0),
711
                    max_new_tokens: Some(5),
Nicolas Patry's avatar
Nicolas Patry committed
712
713
714
715
716
717
718
719
720
721
722
                    ..default_parameters()
                },
            })
            .await
            .unwrap();

        let valid_request = validation
            .validate(GenerateRequest {
                inputs: "Hello".to_string(),
                parameters: GenerateParameters {
                    top_n_tokens: None,
723
                    max_new_tokens: Some(5),
Nicolas Patry's avatar
Nicolas Patry committed
724
725
726
727
728
729
730
731
                    ..default_parameters()
                },
            })
            .await
            .unwrap();

        assert_eq!(valid_request.top_n_tokens, 0);
    }
732
}