1. 13 Apr, 2022 1 commit
    • Tim Hatch's avatar
      apply import merging for fbcode/vision/fair (2 of 2) · 34bbb3ad
      Tim Hatch authored
      Summary:
      Applies new import merging and sorting from µsort v1.0.
      
      When merging imports, µsort will make a best-effort to move associated
      comments to match merged elements, but there are known limitations due to
      the diynamic nature of Python and developer tooling. These changes should
      not produce any dangerous runtime changes, but may require touch-ups to
      satisfy linters and other tooling.
      
      Note that µsort uses case-insensitive, lexicographical sorting, which
      results in a different ordering compared to isort. This provides a more
      consistent sorting order, matching the case-insensitive order used when
      sorting import statements by module name, and ensures that "frog", "FROG",
      and "Frog" always sort next to each other.
      
      For details on µsort's sorting and merging semantics, see the user guide:
      https://usort.readthedocs.io/en/stable/guide.html#sorting
      
      Reviewed By: bottler
      
      Differential Revision: D35553814
      
      fbshipit-source-id: be49bdb6a4c25264ff8d4db3a601f18736d17be1
      34bbb3ad
  2. 04 Apr, 2022 1 commit
    • Jeremy Reizenstein's avatar
      logging · 199309fc
      Jeremy Reizenstein authored
      Summary: Use logging instead of printing in the internals of implicitron.
      
      Reviewed By: davnov134
      
      Differential Revision: D35247581
      
      fbshipit-source-id: be5ddad5efe1409adbae0575d35ade6112b3be63
      199309fc
  3. 01 Apr, 2022 1 commit
    • Roman Shapovalov's avatar
      Type safety fixes · a999fc22
      Roman Shapovalov authored
      Summary: Pyre expects Mapping for ** operator.
      
      Reviewed By: bottler
      
      Differential Revision: D35288632
      
      fbshipit-source-id: 34d6f26ad912b3a5046f440922bb6ed2fd86f533
      a999fc22
  4. 24 Mar, 2022 2 commits
    • Roman Shapovalov's avatar
      Using the new dataset idx API everywhere. · e2622d79
      Roman Shapovalov authored
      Summary: Using the API from D35012121 everywhere.
      
      Reviewed By: bottler
      
      Differential Revision: D35045870
      
      fbshipit-source-id: dab112b5e04160334859bbe8fa2366344b6e0f70
      e2622d79
    • Roman Shapovalov's avatar
      API for accessing frames in order in Implicitron dataset. · c0bb49b5
      Roman Shapovalov authored
      Summary: We often want to iterate over frames in the sequence in temporal order. This diff provides the API to do that. `seq_to_idx` should probably be considered to have `protected` visibility.
      
      Reviewed By: davnov134
      
      Differential Revision: D35012121
      
      fbshipit-source-id: 41896672ec35cd62f3ed4be3aa119efd33adada1
      c0bb49b5
  5. 21 Mar, 2022 1 commit