Commit ff9c6612 authored by Jeremy Reizenstein's avatar Jeremy Reizenstein Committed by Facebook GitHub Bot
Browse files

Use old style isfinite

Summary: Avoid using the newish member function isfinite. We use torch.isfinite instead for torch 1.4.0 compatibility.

Reviewed By: nikhilaravi

Differential Revision: D26946672

fbshipit-source-id: 853c3716f40061152f1ea54a39eb60b565de7c2c
parent 4bb3fff5
...@@ -354,7 +354,7 @@ class TestPointsToVolumes(TestCaseMixin, unittest.TestCase): ...@@ -354,7 +354,7 @@ class TestPointsToVolumes(TestCaseMixin, unittest.TestCase):
# this does not produce grads w.r.t. xyz # this does not produce grads w.r.t. xyz
self.assertIsNone(field.grad) self.assertIsNone(field.grad)
else: else:
self.assertTrue(field.grad.data.isfinite().all()) self.assertTrue(torch.isfinite(field.grad.data).all())
def _check_volume_slice_color_density( def _check_volume_slice_color_density(
self, V, split_dim, interp_mode, clr_gt, slice_type, border=3 self, V, split_dim, interp_mode, clr_gt, slice_type, border=3
......
...@@ -163,7 +163,7 @@ class TestRaymarching(TestCaseMixin, unittest.TestCase): ...@@ -163,7 +163,7 @@ class TestRaymarching(TestCaseMixin, unittest.TestCase):
loss = features_render.mean() loss = features_render.mean()
loss.backward() loss.backward()
for field in (rays_densities, rays_features): for field in (rays_densities, rays_features):
self.assertTrue(field.grad.data.isfinite().all()) self.assertTrue(torch.isfinite(field.grad.data).all())
def test_absorption_only(self): def test_absorption_only(self):
""" """
...@@ -193,4 +193,4 @@ class TestRaymarching(TestCaseMixin, unittest.TestCase): ...@@ -193,4 +193,4 @@ class TestRaymarching(TestCaseMixin, unittest.TestCase):
# check differentiability # check differentiability
loss = opacities_render.mean() loss = opacities_render.mean()
loss.backward() loss.backward()
self.assertTrue(rays_densities.grad.data.isfinite().all()) self.assertTrue(torch.isfinite(rays_densities.grad.data).all())
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment