Commit c3a6ab02 authored by David Novotny's avatar David Novotny Committed by Facebook GitHub Bot
Browse files

Bug-fix visualize reconstruction

Summary:
Addresses the following issue:
https://github.com/facebookresearch/pytorch3d/issues/1345#issuecomment-1272881244

I.e., when installed from conda, `pytorch3d_implicitron_visualizer` crashes since it invokes `main()` while `main` requires a single positional arg `argv`.

Reviewed By: shapovalov

Differential Revision: D41533497

fbshipit-source-id: e53a923eb8b2f0f9c0e92e9c0866d9cb310c4799
parent 60ab1cdb
...@@ -141,7 +141,7 @@ def _get_config_from_experiment_directory(experiment_directory) -> DictConfig: ...@@ -141,7 +141,7 @@ def _get_config_from_experiment_directory(experiment_directory) -> DictConfig:
return OmegaConf.merge(get_default_args(Experiment), config) return OmegaConf.merge(get_default_args(Experiment), config)
def main(argv) -> None: def main(argv=sys.argv) -> None:
# automatically parses arguments of visualize_reconstruction # automatically parses arguments of visualize_reconstruction
cfg = OmegaConf.create(get_default_args(visualize_reconstruction)) cfg = OmegaConf.create(get_default_args(visualize_reconstruction))
cfg.update(OmegaConf.from_cli(argv)) cfg.update(OmegaConf.from_cli(argv))
...@@ -150,4 +150,4 @@ def main(argv) -> None: ...@@ -150,4 +150,4 @@ def main(argv) -> None:
if __name__ == "__main__": if __name__ == "__main__":
main(sys.argv) main()
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment