• Jeremy Reizenstein's avatar
    Fix batching bug from TexturesUV packed ambiguity, other textures tidyup · 9a50cf80
    Jeremy Reizenstein authored
    Summary:
    faces_uvs_packed and verts_uvs_packed were only used in one place and the definition of the former was ambiguous. This meant that the wrong coordinates could be used for meshes other than the first in the batch. I have therefore removed both functions and build their common result inline. Added a test that a simple batch of two meshes is rendered consistently with the rendering of each alone. This test would have failed before.
    
    I hope this fixes https://github.com/facebookresearch/pytorch3d/issues/283.
    
    Some other small improvements to the textures code.
    
    Reviewed By: nikhilaravi
    
    Differential Revision: D23161936
    
    fbshipit-source-id: f99b560a46f6b30262e07028b049812bc04350a7
    9a50cf80
test_texturing.py 29.1 KB