Skip to content
GitLab
Menu
Projects
Groups
Snippets
Loading...
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
Menu
Open sidebar
OpenDAS
opencompass
Commits
64fde73b
Unverified
Commit
64fde73b
authored
Mar 12, 2024
by
Fengzhe Zhou
Committed by
GitHub
Mar 12, 2024
Browse files
[Fix] Use logger.error on failure (#960)
parent
ed663ca1
Changes
4
Hide whitespace changes
Inline
Side-by-side
Showing
4 changed files
with
4 additions
and
4 deletions
+4
-4
opencompass/runners/local.py
opencompass/runners/local.py
+1
-1
opencompass/runners/local_api.py
opencompass/runners/local_api.py
+1
-1
opencompass/runners/slurm.py
opencompass/runners/slurm.py
+1
-1
opencompass/runners/slurm_sequential.py
opencompass/runners/slurm_sequential.py
+1
-1
No files found.
opencompass/runners/local.py
View file @
64fde73b
...
...
@@ -189,7 +189,7 @@ class LocalRunner(BaseRunner):
stderr
=
stdout
)
if
result
.
returncode
!=
0
:
logger
.
warning
(
f
'task
{
task_name
}
fail, see
\n
{
out_path
}
'
)
logger
.
error
(
f
'task
{
task_name
}
fail, see
\n
{
out_path
}
'
)
finally
:
# Clean up
os
.
remove
(
param_file
)
...
...
opencompass/runners/local_api.py
View file @
64fde73b
...
...
@@ -128,7 +128,7 @@ def launch(task: BaseTask, tokens: SyncManager.Semaphore):
traceback
.
print_exc
()
# reset stdout and stderr
reset_std
()
logger
.
warning
(
f
'task
{
task_name
}
fail, see
\n
{
out_path
}
'
)
logger
.
error
(
f
'task
{
task_name
}
fail, see
\n
{
out_path
}
'
)
returncode
=
1
else
:
# reset stdout and stderr
...
...
opencompass/runners/slurm.py
View file @
64fde73b
...
...
@@ -151,7 +151,7 @@ class SlurmRunner(BaseRunner):
stderr
=
stdout
)
if
result
.
returncode
!=
0
and
not
self
.
debug
:
logger
.
warning
(
f
'task
{
task_name
}
fail, see
\n
{
out_path
}
'
)
logger
.
error
(
f
'task
{
task_name
}
fail, see
\n
{
out_path
}
'
)
finally
:
# Clean up
os
.
remove
(
param_file
)
...
...
opencompass/runners/slurm_sequential.py
View file @
64fde73b
...
...
@@ -242,7 +242,7 @@ class SlurmSequentialRunner(BaseRunner):
retry
-=
1
cmd
=
get_cmd
()
else
:
logger
.
warning
(
logger
.
error
(
f
'task
{
task_name
}
fail, see
\n
{
out_path
}
'
)
break
else
:
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
.
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment