1. 13 May, 2025 1 commit
  2. 12 May, 2025 5 commits
  3. 11 May, 2025 2 commits
  4. 10 May, 2025 5 commits
  5. 08 May, 2025 5 commits
  6. 07 May, 2025 5 commits
  7. 06 May, 2025 5 commits
  8. 05 May, 2025 7 commits
  9. 04 May, 2025 1 commit
  10. 03 May, 2025 3 commits
  11. 02 May, 2025 1 commit
    • Jesse Gross's avatar
      ggml: Fix race that resulted in "context canceled" when loading · a6ef73f4
      Jesse Gross authored
      Successfully completing processing with an errgroup cancels the
      associated context. However, we also have a goroutine that is checking
      for cancelation of the context. As a result, there is a race where
      the goroutine can pick up the cancelation and report an error,
      replacing the sucessful error message.
      
      To avoid that, this replaces the goroutine with a cancelation check
      when we are reading files. This also has the advantage of stopping
      all reads relatively quickly on error and also ensuring that there are
      no outstanding I/O operations when we return in this case.
      
      The downside is that if a file read blocks forever (for example, over
      the network) then cancelation of the context effectively won't be
      honored. However, this is also true for other smaller files we read
      and the tensors are read in small chunks (128K), so it's consistent
      and better on balance overall.
      a6ef73f4