"tests/vscode:/vscode.git/clone" did not exist on "a72a057d62d0adb2743b20968c72ae9cb5e5d62b"
  1. 08 Mar, 2025 2 commits
  2. 07 Mar, 2025 13 commits
  3. 04 Mar, 2025 1 commit
    • Michael Yang's avatar
      ml/backend/ggml: consolidate system info logging · 05a01fde
      Michael Yang authored
      - output backend system info when initializing the backend. this ensures
        this information is always present without needing to be called
        explicitly
      - convert to structured logging
      - enumerate devices rather than backends since devices are ordered
      - track device indices grouped by device name
      05a01fde
  4. 03 Mar, 2025 1 commit
  5. 02 Mar, 2025 4 commits
    • Jesse Gross's avatar
      ml: Enable support for flash attention · 21aa666a
      Jesse Gross authored
      The GGML flash attention kernel has specific requirements for
      padding and permutation. This adds support to the KV cache
      for conforming to these requirements so that flash attention
      can be enabled.
      
      Flash attention can be used in the same situations as the llama
      engine and is enabled by the user in the same way.
      21aa666a
    • Jesse Gross's avatar
      ml: Empty tensor constructor for tensors · ee141cc8
      Jesse Gross authored
      In cases where we allocate a tensor and then fully overwrite it with
      copied data, it is wasteful to first zero out the memory.
      ee141cc8
    • Jesse Gross's avatar
      ggml-backend: Store parent backend as part of tensor · 55e5776c
      Jesse Gross authored
      It can be important for a tensor to know what backend it came from -
      for example, to know if flash attention is enabled.
      55e5776c
    • Jesse Gross's avatar
      attention: Remove unnecessary contiguous operations · 854a9195
      Jesse Gross authored
      Prior to performing attention, we need to permute query, key
      and value. Currently we call Contiguous after each of these
      permutations, which is correct but expensive. Avoiding the
      3 calls to Contiguous increases performance by over 20%.
      
      The permutations of query and key do not violate the continuity
      rules for mulmat and the Contiguous call can be simply removed.
      
      Value requires a different permutation and does require Contiguous.
      However, we can use the copy into the cache as a way to perform this
      without further overhead.
      
      To support this and avoid unexpected tensor shapes that are seen by
      models, we need tighter integration between attention, cache
      and backend. Future optimization will also likely need this structure
       - for example, flash attention has special padding requirements in
      the cache and other backends may have their own needs.
      
      This further contains the operations that go into attention so that
      these and other optimizations can be handled transparently. Models
      that have special requirements for attention can still implement
      their own version of it.
      854a9195
  6. 27 Feb, 2025 5 commits
  7. 25 Feb, 2025 1 commit
    • Blake Mizerany's avatar
      .github: always run tests, and other helpful fixes (#9348) · 0d694793
      Blake Mizerany authored
      During work on our new registry client, I ran into frustrations with CI
      where a misspelling in a comment caused the linter to fail, which caused
      the tests to not run, which caused the build to not be cached, which
      caused the next run to be slow, which caused me to be sad.
      
      This commit address these issues, and pulls in some helpful changes
      we've had in CI on ollama.com for some time now.
      
      They are:
      
      * Always run tests, even if the other checks fail.
      
      Tests are the most important part of CI, and should always run. Failures
      in tests can be correlated with failures in other checks, and can help
      surface the root cause of the failure sooner. This is especially
      important when the failure is platform specific, and the tests are not
      platform independent.
      
      * Check that `go generate` is clean.
      
      This prevents 'go generate' abuse regressions. This codebase used to use
      it to generate platform specific binary build artifacts. Let's make sure
      that does not happen again and this powerful tool is used correctly, and
      the generated code is checked in.
      
      Also, while adding `go generate` the check, it was revealed that the
      generated metal code was putting dates in the comments, resulting in
      non-deterministic builds. This is a bad practice, and this commit fixes
      that. Git tells us the most important date: the commit date along with
      other associated changes.
      
      * Check that `go mod tidy` is clean.
      
      A new job to check that `go mod tidy` is clean was added, to prevent
      easily preventable merge conflicts or go.mod changes being deferred to a
      future PR that is unrelated to the change that caused the go.mod to
      change.
      
      * More robust caching.
      
      We now cache the go build cache, and the go mod download cache
      independently. This is because the download cache contains zips that can
      be unpacked in parallel faster than they can be fetched and extracted by
      tar. This speeds up the build significantly.
      
      The linter is hostile enough. It does not need to also punish us with
      longer build times due to small failures like misspellings.
      0d694793
  8. 24 Feb, 2025 1 commit
  9. 21 Feb, 2025 2 commits
  10. 20 Feb, 2025 2 commits
    • Jesse Gross's avatar
      ggml-backend: Don't recreate the scheduler for each context · e5bcc51a
      Jesse Gross authored
      We don't need to create and destroy the GGML scheduler for every
      context. This introduces extra CPU overhead for every forward
      pass and extra memory for contexts that don't actually get scheduled
      (for example, KV caches). We can instead just have one scheduler
      for the backend and reset it each time we call Compute.
      
      This improves token generation performance by 1-2% and removes
      scheduler create/destroy from profile traces.
      e5bcc51a
    • Jesse Gross's avatar
      ollamarunner: Pass runner performance parameters to backends · bd6a7d5e
      Jesse Gross authored
      Currently the following parameters are in the runner but not used:
       - numGPULayers
       - mainGPU
       - threads
       - tensorSplit
      
      This passes them through to the backend, which is where they would
      actually get used. However, the GGML backend does not yet do anything
      with them.
      bd6a7d5e
  11. 19 Feb, 2025 1 commit
  12. 18 Feb, 2025 1 commit
    • Michael Yang's avatar
      build: remove backend build for sapphirerapids · 5f8c0318
      Michael Yang authored
      sapphire rapids has amx support but it ends up having a negative
      performance impact.
      
      emerald rapids also has amx support with a positive performance impact
      however there's no reasonable way in ggml to differentiate between the
      two. the impact is small (~6%) so disable amx entirely for simplicity
      5f8c0318
  13. 14 Feb, 2025 6 commits