Skip to content

GitLab

Unverified Commit 7e5c8eee authored by 湛露先生's avatar 湛露先生 Committed by GitHub
Browse files

file close check and close. (#10554) 


Signed-off-by: default avatarzhanluxianshen <zhanluxianshen@163.com>
parent 6a74bba7
Hide whitespace changes
Inline Side-by-side
Showing with 2 additions and 0 deletions
convert/convert_test.go
View file @ 7e5c8eee
...@@ -130,6 +130,7 @@ func TestConvertModel(t *testing.T) { ...@@ -130,6 +130,7 @@ func TestConvertModel(t *testing.T) {
if err != nil { if err != nil {
t.Fatal(err) t.Fatal(err)
} }
defer expectFile.Close()
var expect map[string]string var expect map[string]string
if err := json.NewDecoder(expectFile).Decode(&expect); err != nil { if err := json.NewDecoder(expectFile).Decode(&expect); err != nil {
......
integration/utils_test.go
View file @ 7e5c8eee
...@@ -217,6 +217,7 @@ func InitServerConnection(ctx context.Context, t *testing.T) (*api.Client, strin ...@@ -217,6 +217,7 @@ func InitServerConnection(ctx context.Context, t *testing.T) (*api.Client, strin
slog.Error("failed to open server log", "logfile", lifecycle.ServerLogFile, "error", err) slog.Error("failed to open server log", "logfile", lifecycle.ServerLogFile, "error", err)
return return
} }
defer fp.Close()
data, err := io.ReadAll(fp) data, err := io.ReadAll(fp)
if err != nil { if err != nil {
slog.Error("failed to read server log", "logfile", lifecycle.ServerLogFile, "error", err) slog.Error("failed to read server log", "logfile", lifecycle.ServerLogFile, "error", err)
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment