"git@developer.sourcefind.cn:OpenDAS/ollama.git" did not exist on "3bc8b9832b3bfab9ddca01ec0ebc012303362361"
Unverified Commit 7ac6d462 authored by Jeffrey Morgan's avatar Jeffrey Morgan Committed by GitHub
Browse files

server: return empty slice on empty `/api/embed` request (#5713)

* server: return empty slice on empty `/api/embed` request

* fix tests
parent 8288ec88
...@@ -206,7 +206,7 @@ type EmbedRequest struct { ...@@ -206,7 +206,7 @@ type EmbedRequest struct {
// EmbedResponse is the response from [Client.Embed]. // EmbedResponse is the response from [Client.Embed].
type EmbedResponse struct { type EmbedResponse struct {
Model string `json:"model"` Model string `json:"model"`
Embeddings [][]float32 `json:"embeddings,omitempty"` Embeddings [][]float32 `json:"embeddings"`
} }
// EmbeddingRequest is the request passed to [Client.Embeddings]. // EmbeddingRequest is the request passed to [Client.Embeddings].
......
...@@ -306,8 +306,12 @@ func Test_Routes(t *testing.T) { ...@@ -306,8 +306,12 @@ func Test_Routes(t *testing.T) {
t.Fatalf("expected model t-bone, got %s", embedResp.Model) t.Fatalf("expected model t-bone, got %s", embedResp.Model)
} }
if embedResp.Embeddings != nil { if embedResp.Embeddings == nil {
t.Fatalf("expected embeddings to be nil, got %v", embedResp.Embeddings) t.Fatalf("expected embeddings to not be nil, got %v", embedResp.Embeddings)
}
if len(embedResp.Embeddings) != 0 {
t.Fatalf("expected embeddings to be empty, got %v", embedResp.Embeddings)
} }
}, },
}, },
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment