Commit 2fa1db43 authored by Daniel Hiltgen's avatar Daniel Hiltgen
Browse files

Don't hard fail on sparse setup error

It seems this can fail in some casees, but proceed
with the download anyway.
parent e9aa5117
......@@ -216,9 +216,7 @@ func (b *blobDownload) run(ctx context.Context, requestURL *url.URL, opts *regis
return err
}
defer file.Close()
if err := setSparse(file); err != nil {
return err
}
setSparse(file)
_ = file.Truncate(b.Total)
......
......@@ -4,6 +4,5 @@ package server
import "os"
func setSparse(file *os.File) error {
return nil
func setSparse(*os.File) {
}
......@@ -6,8 +6,9 @@ import (
"golang.org/x/sys/windows"
)
func setSparse(file *os.File) error {
return windows.DeviceIoControl(
func setSparse(file *os.File) {
// exFat (and other FS types) don't support sparse files, so ignore errors
windows.DeviceIoControl( //nolint:errcheck
windows.Handle(file.Fd()), windows.FSCTL_SET_SPARSE,
nil, 0,
nil, 0,
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment