Skip to content

GitLab

Unverified Commit 2dd029de authored by Michael Yang's avatar Michael Yang Committed by GitHub
Browse files

remove unnecessary code (#13502) 

slog is already lazily evaluated so this code is completely redundant
parent 903b1fc9
Hide whitespace changes
Inline Side-by-side
Showing with 1 addition and 11 deletions
model/bytepairencoding.go
View file @ 2dd029de
...@@ -2,9 +2,7 @@ package model ...@@ -2,9 +2,7 @@ package model
import ( import (
"cmp" "cmp"
"fmt"
"iter" "iter"
"log/slog"
"slices" "slices"
"strings" "strings"
...@@ -245,14 +243,6 @@ func (bpe BytePairEncoding) Encode(s string, addSpecial bool) ([]int32, error) { ...@@ -245,14 +243,6 @@ func (bpe BytePairEncoding) Encode(s string, addSpecial bool) ([]int32, error) {
return ids, nil return ids, nil
} }
type lazyIdsString struct {
ids []int32
}
func (l lazyIdsString) LogValue() slog.Value {
return slog.AnyValue(fmt.Sprint(l.ids))
}
func (bpe BytePairEncoding) Decode(ids []int32) (string, error) { func (bpe BytePairEncoding) Decode(ids []int32) (string, error) {
var sb strings.Builder var sb strings.Builder
for _, id := range ids { for _, id := range ids {
...@@ -277,6 +267,6 @@ func (bpe BytePairEncoding) Decode(ids []int32) (string, error) { ...@@ -277,6 +267,6 @@ func (bpe BytePairEncoding) Decode(ids []int32) (string, error) {
} }
} }
logutil.Trace("decoded", "string", sb.String(), "from", lazyIdsString{ids: ids}) logutil.Trace("decoded", "string", sb.String(), "from", ids)
return sb.String(), nil return sb.String(), nil
} }
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment