Skip to content

GitLab

Unverified Commit 06d4fba8 authored by frob's avatar frob Committed by GitHub
Browse files

openai: align chat temperature and frequency_penalty options with completion (#6688)

parent 108fb6c1
Hide whitespace changes
Inline Side-by-side
Showing with 6 additions and 6 deletions
openai/openai.go
View file @ 06d4fba8
...@@ -452,7 +452,7 @@ func fromChatRequest(r ChatCompletionRequest) (*api.ChatRequest, error) { ...@@ -452,7 +452,7 @@ func fromChatRequest(r ChatCompletionRequest) (*api.ChatRequest, error) {
} }
if r.Temperature != nil { if r.Temperature != nil {
options["temperature"] = *r.Temperature * 2.0 options["temperature"] = *r.Temperature
} else { } else {
options["temperature"] = 1.0 options["temperature"] = 1.0
} }
...@@ -462,11 +462,11 @@ func fromChatRequest(r ChatCompletionRequest) (*api.ChatRequest, error) { ...@@ -462,11 +462,11 @@ func fromChatRequest(r ChatCompletionRequest) (*api.ChatRequest, error) {
} }
if r.FrequencyPenalty != nil { if r.FrequencyPenalty != nil {
options["frequency_penalty"] = *r.FrequencyPenalty * 2.0 options["frequency_penalty"] = *r.FrequencyPenalty
} }
if r.PresencePenalty != nil { if r.PresencePenalty != nil {
options["presence_penalty"] = *r.PresencePenalty * 2.0 options["presence_penalty"] = *r.PresencePenalty
} }
if r.TopP != nil { if r.TopP != nil {
......
openai/openai_test.go
View file @ 06d4fba8
...@@ -102,9 +102,9 @@ func TestChatMiddleware(t *testing.T) { ...@@ -102,9 +102,9 @@ func TestChatMiddleware(t *testing.T) {
"num_predict": 999.0, // float because JSON doesn't distinguish between float and int "num_predict": 999.0, // float because JSON doesn't distinguish between float and int
"seed": 123.0, "seed": 123.0,
"stop": []any{"\n", "stop"}, "stop": []any{"\n", "stop"},
"temperature": 6.0, "temperature": 3.0,
"frequency_penalty": 8.0, "frequency_penalty": 4.0,
"presence_penalty": 10.0, "presence_penalty": 5.0,
"top_p": 6.0, "top_p": 6.0,
}, },
Format: "json", Format: "json",
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment