• Jesse Gross's avatar
    model: Update encoder cache to use multimodal input processing handler · a1cda80b
    Jesse Gross authored
    The encoder cache needs to know the position of images in the input
    stream so that it knows when to delete them. Previously images didn't
    have a position, so we implied one by breaking batches before an
    image and then assuming the image was in the first position. However,
    multimodal objects are now given explicit positions in the input
    stream, so we can use that instead.
    
    Breaking batches was also a way to simulate a cross attention mask
    for mllama. However, given that it only supports a single sequence
    and a single image, this mask doesn't serve any real purpose.
    Removing the batch break does not appear to affect the quality of
    the output.
    
    Most of this is simply moving the input data structures to a new
    package to avoid import cycles.
    a1cda80b
encoder.go 3.24 KB