• Jesse Gross's avatar
    runner.go: Hard fail on errors rather than potentially infinite looping · 3fc1dc0e
    Jesse Gross authored
    We try to recover from errors by dropping the tokens that caused the
    problem and re-trying. However, dropping the tokens is not correct
    and continuing often leads to infinite loops. To avoid, this we
    end the sequence if such a condition is detected, which is also
    surprising.
    
    At this point, it is better to just report the error. This will make
    it easier to find problems and the alternatives are perhaps even more
    surprising to users.
    
    This is not a very satisfactory solution either - we should isolate
    the error and return it to the user without killing the whole process.
    However, this is an incremental step and consistent with most other
    failures (which either manifest as abort() or panic).
    3fc1dc0e
runner.go 24.1 KB