0030-fix-bakllava-regression.patch 1022 Bytes
Newer Older
Daniel Hiltgen's avatar
Daniel Hiltgen committed
1
2
3
4
5
6
7
8
9
10
11
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
From: Daniel Hiltgen <daniel@ollama.com>
Date: Tue, 11 Nov 2025 11:39:43 -0800
Subject: [PATCH] fix bakllava regression

Rever to prior logic of assuming an empty projector type is mlp
---
 tools/mtmd/clip.cpp | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/tools/mtmd/clip.cpp b/tools/mtmd/clip.cpp
12
index 84a3796b5..d3a37842d 100644
Daniel Hiltgen's avatar
Daniel Hiltgen committed
13
14
--- a/tools/mtmd/clip.cpp
+++ b/tools/mtmd/clip.cpp
15
@@ -960,6 +960,10 @@ struct clip_model_loader {
Daniel Hiltgen's avatar
Daniel Hiltgen committed
16
17
18
19
20
21
22
23
24
25
             if (proj_type.empty()) {
                 if (modality == CLIP_MODALITY_VISION) {
                     get_string(KEY_VISION_PROJ_TYPE, proj_type, false);
+                    if (proj_type.empty()) {
+                        // Assume MLP if no projector type listed
+                        proj_type = "mlp";
+                    }
                 } else if (modality == CLIP_MODALITY_AUDIO) {
                     get_string(KEY_AUDIO_PROJ_TYPE, proj_type, false);
                 } else {