fix trial status not correct when trial is early stoped (#4005)

ts/nni_manager/core/nnimanager.ts

@@ -681,7 +681,12 @@ class NNIManager implements Manager {
                     this.currSubmittedTrialNum++;
                     this.log.info('submitTrialJob: form:', form);
                     const trialJobDetail: TrialJobDetail = await this.trainingService.submitTrialJob(form);
-                    setTimeout(async () => this.stopTrialJobIfOverMaxDurationTimer(trialJobDetail.id), 1000 * this.maxTrialDuration);
+                    if(this.maxTrialDuration !== Infinity){
+                        // Fix timeout warning : Infinity does not fit into a 32-bit signed integer(2147483647).
+                        const duration = (this.maxTrialDuration * 1000) > 2147483647 ? 2147483647 : this.maxTrialDuration * 1000;
+                        setTimeout(async () => this.stopTrialJobIfOverMaxDurationTimer(trialJobDetail.id), duration);
+                    }
+
                     const Snapshot: TrialJobDetail = Object.assign({}, trialJobDetail);
                     await this.storeExperimentProfile();
                     this.trialJobs.set(trialJobDetail.id, Snapshot);

ts/nni_manager/training_service/local/localTrainingService.ts

@@ -237,8 +237,10 @@ class LocalTrainingService implements TrainingService {
             return Promise.resolve();
         }
         tkill(trialJob.pid, 'SIGTERM');
+        this.setTrialJobStatus(trialJob, getJobCancelStatus(isEarlyStopped));
+
         const startTime = Date.now();
-        while(await isAlive(trialJob.pid)) {    
+        while(await isAlive(trialJob.pid)) {
             if (Date.now() - startTime > 4999) {
                 tkill(trialJob.pid, 'SIGKILL', (err) => {
                     if (err) {
@@ -250,8 +252,6 @@ class LocalTrainingService implements TrainingService {
             await delay(500);
         }
 
-        this.setTrialJobStatus(trialJob, getJobCancelStatus(isEarlyStopped));
-
         return Promise.resolve();
     }