Unverified Commit de1ae178 authored by Lijiao's avatar Lijiao Committed by GitHub
Browse files

fix some bugs in v1.4 bug bash (#2066)

parent b7045b19
......@@ -172,7 +172,7 @@ class NavCon extends React.Component<NavProps, NavState> {
/>
<CommandBarButton
iconProps={infoIconAbout}
text="about"
text="About"
menuProps={aboutProps}
/>
</Stack>
......
......@@ -56,7 +56,7 @@ class TrialsDetail extends React.Component<TrialsDetailProps, TrialDetailState>
return;
}
switch (this.state.searchType) {
case 'id':
case 'Id':
filter = (trial): boolean => trial.info.id.toUpperCase().includes(targetValue.toUpperCase());
break;
case 'Trial No.':
......@@ -65,7 +65,7 @@ class TrialsDetail extends React.Component<TrialsDetailProps, TrialDetailState>
case 'Status':
filter = (trial): boolean => trial.info.status.toUpperCase().includes(targetValue.toUpperCase());
break;
case 'parameters':
case 'Parameters':
// TODO: support filters like `x: 2` (instead of `"x": 2`)
filter = (trial): boolean => JSON.stringify(trial.info.hyperParameters, null, 4).includes(targetValue);
break;
......
......@@ -128,7 +128,7 @@ class TableList extends React.Component<TableListProps, TableListState> {
name: 'Default metric',
className: 'leftTitle',
key: 'accuracy',
fieldName: 'accuracy',
fieldName: 'latestAccuracy',
minWidth: 200,
maxWidth: 300,
isResizable: true,
......@@ -534,8 +534,8 @@ class TableList extends React.Component<TableListProps, TableListState> {
}
UNSAFE_componentWillReceiveProps(nextProps: TableListProps): void {
const { columnList } = nextProps;
this.setState({ tableColumns: this.initTableColumnList(columnList) });
const { columnList, tableSource } = nextProps;
this.setState({ tableSourceForSort: tableSource, tableColumns: this.initTableColumnList(columnList) });
}
render(): React.ReactNode {
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment