fix datastore for multiple final result (#129)

bae7e025 · chicm-ms · GitHub · d3506e34 · bae7e025
Unverified Commit bae7e025 authored Sep 27, 2018 by chicm-ms Committed by GitHub Sep 27, 2018
Hide whitespace changes
Inline Side-by-side

Showing with 4 additions and 5 deletions

src/nni_manager/core/nniDataStore.ts src/nni_manager/core/nniDataStore.ts +4 -5

No files found.
--- a/src/nni_manager/core/nniDataStore.ts
+++ b/src/nni_manager/core/nniDataStore.ts
@@ -160,12 +160,11 @@ class NNIDataStore implements DataStore {

    private async getFinalMetricData(trialJobId: string): Promise<any> {
        const metrics: MetricDataRecord[] = await this.getMetricData(trialJobId, 'FINAL');
-        assert(metrics.length <= 1);
-        if (metrics.length === 1) {
-            return metrics[0];
-        } else {
-            return undefined;
+        if (metrics.length > 1) {
+            this.log.error(`Found multiple final results for trial job: ${trialJobId}`);
        }
+
+        return metrics[0];
    }

    private getJobStatusByLatestEvent(event: TrialJobEvent): TrialJobStatus {