Bug bash (#4930)

ts/webui/src/components/experiment/trialdetail/chart/DefaultMetricPoint.tsx

@@ -6,6 +6,7 @@ import { EXPERIMENT, TRIALS } from '@static/datamodel';
 import { TooltipForAccuracy, EventMap } from '@static/interface';
 import { reformatRetiariiParameter } from '@static/function';
 import { gap15 } from '@components/fluent/ChildrenGap';
+import { optimizeModeValue } from './optimizeMode';
 import 'echarts/lib/chart/scatter';
 import 'echarts/lib/component/tooltip';
 import 'echarts/lib/component/title';
@@ -45,7 +46,7 @@ class DefaultPoint extends React.Component<DefaultPointProps, DefaultPointState>
             bestCurveEnabled: false,
             startY: 0, // dataZoomY
             endY: 100,
-            userSelectOptimizeMode: EXPERIMENT.optimizeMode || 'maximize'
+            userSelectOptimizeMode: optimizeModeValue(EXPERIMENT.optimizeMode)
         };
     }
 

ts/webui/src/components/experiment/trialdetail/chart/Para.tsx

@@ -7,6 +7,7 @@ import { filterByStatus } from '@static/function';
 import { EXPERIMENT, TRIALS } from '@static/datamodel';
 import { TableObj, SingleAxis, MultipleAxes } from '@static/interface';
 import ChangeColumnComponent from '../ChangeColumnComponent';
+import { optimizeModeValue } from './optimizeMode';
 
 import 'parcoord-es/dist/parcoords.css';
 import '@style/button.scss';
@@ -50,7 +51,7 @@ class Para extends React.Component<ParaProps, ParaState> {
             dimName: [],
             primaryMetricKey: 'default',
             selectedPercent: '1',
-            userSelectOptimizeMode: EXPERIMENT.optimizeMode || 'maximize',
+            userSelectOptimizeMode: optimizeModeValue(EXPERIMENT.optimizeMode),
             noChart: true,
             customizeColumnsDialogVisible: false,
             availableDimensions: [],

ts/webui/src/components/experiment/trialdetail/chart/optimizeMode.ts

+function optimizeModeValue(optimizeMode: string) {
+    // 'unknown' value is from experiment.ts file optimizeMode function
+    return optimizeMode === 'unknown' ? 'maximize' : optimizeMode;
+}
+
+export { optimizeModeValue };

ts/webui/src/components/experiment/trialdetail/table/tableFunction/search/Search.tsx

@@ -6,7 +6,8 @@ import {
     IContextualMenuProps,
     IContextualMenuItem,
     DirectionalHint,
-    SearchBox
+    SearchBox,
+    PrimaryButton
 } from '@fluentui/react';
 import { EXPERIMENT } from '@static/datamodel';
 import { SearchItems } from '@static/interface';
@@ -281,7 +282,6 @@ function Search(props): any {
             }
         }
 
-        console.info(newSearchFilter); // eslint-disable-line
         changeTableListPage(newSearchFilter);
     }
 
@@ -296,7 +296,7 @@ function Search(props): any {
                 <DefaultButton text='Filter' menuProps={searchMenuProps} />
                 {/* search input: store filter conditons, also, user could input filter conditions, could search */}
                 <SearchBox
-                    styles={{ root: { width: 530 } }}
+                    styles={{ root: { width: 400 } }}
                     placeholder='Search'
                     onChange={updateSearchText}
                     value={searchInputVal}
@@ -304,6 +304,7 @@ function Search(props): any {
                     onEscape={clearFliter}
                     onClear={clearFliter}
                 />
+                <PrimaryButton text='Search' onClick={startFilter} />
             </Stack>
         </div>
     );

ts/webui/yarn.lock

@@ -3585,9 +3585,9 @@ caniuse-api@^3.0.0:
     lodash.uniq "^4.5.0"
 caniuse-lite@^1.0.0, caniuse-lite@^1.0.30000981, caniuse-lite@^1.0.30001109, caniuse-lite@^1.0.30001286:
-  version "1.0.30001292"
-  resolved "https://registry.yarnpkg.com/caniuse-lite/-/caniuse-lite-1.0.30001292.tgz#4a55f61c06abc9595965cfd77897dc7bc1cdc456"
-  integrity sha512-jnT4Tq0Q4ma+6nncYQVe7d73kmDmE9C3OGTx3MvW7lBM/eY1S1DZTMBON7dqV481RhNiS5OxD7k9JQvmDOTirw==
+  version "1.0.30001352"
+  resolved "https://registry.npmjs.org/caniuse-lite/-/caniuse-lite-1.0.30001352.tgz"
+  integrity sha512-GUgH8w6YergqPQDGWhJGt8GDRnY0L/iJVQcU3eJ46GYf52R8tk0Wxp0PymuFVZboJYXGiCqwozAYZNRjVj6IcA==
 capture-exit@^2.0.0:
   version "2.0.0"