Unverified Commit 5426cfe8 authored by fishyds's avatar fishyds Committed by GitHub
Browse files

[Kubeflow training service] fix bug that wrongly split kube delete cmd into 2 lines (#425)

* [Kubeflow training service] fix bug that wrongly split kube delete cmd into 2 lines

* Adjust white space
parent bc44c745
......@@ -282,8 +282,8 @@ class KubeflowTrainingService implements TrainingService {
return Promise.reject(errorMessage);
}
const result: cpp.childProcessPromise.Result = await cpp.exec(`kubectl delete
${this.kubeflowJobPlural} -l app=${this.NNI_KUBEFLOW_TRIAL_LABEL},expId=${getExperimentId()},trialId=${trialJobId}`);
const result: cpp.childProcessPromise.Result = await cpp.exec(`kubectl delete ${this.kubeflowJobPlural} -l `
+ `app=${this.NNI_KUBEFLOW_TRIAL_LABEL},expId=${getExperimentId()},trialId=${trialJobId}`);
if(result.stderr) {
const errorMessage: string = `kubectl delete ${this.kubeflowJobPlural} for trial ${trialJobId} failed: ${result.stderr}`;
this.log.error(errorMessage);
......@@ -318,7 +318,7 @@ class KubeflowTrainingService implements TrainingService {
this.log.error(mountError);
throw new Error(mountError);
}
}else if(this.kubeflowClusterConfig.keyVault && this.kubeflowClusterConfig.azureStorage){
} else if(this.kubeflowClusterConfig.keyVault && this.kubeflowClusterConfig.azureStorage){
const vaultName = this.kubeflowClusterConfig.keyVault.vaultName;
const valutKeyName = this.kubeflowClusterConfig.keyVault.name;
this.azureStorageAccountName = this.kubeflowClusterConfig.azureStorage.accountName;
......@@ -340,7 +340,7 @@ class KubeflowTrainingService implements TrainingService {
+ `--from-literal=azurestorageaccountname=${this.azureStorageAccountName} `
+ `--from-literal=azurestorageaccountkey=${storageAccountKey}`)
}catch(error){
} catch(error){
this.log.error(`command error: ${error}`);
throw new Error(error);
}
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment