Unverified Commit 4b67c457 authored by liuzhe-lz's avatar liuzhe-lz Committed by GitHub
Browse files

Fix backward incompatible config behavior (#4408)

parent f2ddea0a
...@@ -89,7 +89,7 @@ class ExperimentConfig(ConfigBase): ...@@ -89,7 +89,7 @@ class ExperimentConfig(ConfigBase):
for algo_type in ['tuner', 'assessor', 'advisor']: for algo_type in ['tuner', 'assessor', 'advisor']:
# add placeholder items, so users can write `config.tuner.name = 'random'` # add placeholder items, so users can write `config.tuner.name = 'random'`
if getattr(self, algo_type) is None: if getattr(self, algo_type) is None:
setattr(self, algo_type, _AlgorithmConfig(name='_none_')) setattr(self, algo_type, _AlgorithmConfig(name='_none_', class_args={}))
elif not utils.is_missing(self.training_service): elif not utils.is_missing(self.training_service):
# training service is set via json or constructor # training service is set via json or constructor
if isinstance(self.training_service, list): if isinstance(self.training_service, list):
......
import copy
import os.path import os.path
from pathlib import Path from pathlib import Path
...@@ -46,6 +47,9 @@ minimal_canon = { ...@@ -46,6 +47,9 @@ minimal_canon = {
}, },
} }
minimal_canon_2 = copy.deepcopy(minimal_canon)
minimal_canon_2['tuner']['classArgs'] = {}
## detailed config ## ## detailed config ##
detailed_canon = { detailed_canon = {
...@@ -100,7 +104,7 @@ def test_all(): ...@@ -100,7 +104,7 @@ def test_all():
minimal = ExperimentConfig(**minimal_json) minimal = ExperimentConfig(**minimal_json)
assert minimal.json() == minimal_canon assert minimal.json() == minimal_canon
assert minimal_class.json() == minimal_canon assert minimal_class.json() == minimal_canon_2
detailed = ExperimentConfig.load(expand_path('assets/config.yaml')) detailed = ExperimentConfig.load(expand_path('assets/config.yaml'))
assert detailed.json() == detailed_canon assert detailed.json() == detailed_canon
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment