Fix rest server UT (#489)

src/nni_manager/rest_server/restValidationSchemas.ts

@@ -114,9 +114,9 @@ export namespace ValidationSchemas {
                 codeDir: joi.string(),
                 classFileName: joi.string(),
                 className: joi.string(),
-                classArgs:joi.any(),
+                classArgs: joi.any(),
                 gpuNum: joi.number().min(0),
-                checkpointDir: joi.string()
+                checkpointDir: joi.string().allow('')
             }),
             tuner: joi.object({
                 builtinTunerName: joi.string().valid('TPE', 'Random', 'Anneal', 'Evolution', 'SMAC', 'BatchTuner', 'GridSearch', 'NetworkMorphism'),
@@ -125,7 +125,7 @@ export namespace ValidationSchemas {
                 className: joi.string(),
                 classArgs: joi.any(),
                 gpuNum: joi.number().min(0),
-                checkpointDir: joi.string()
+                checkpointDir: joi.string().allow('')
             }),
             assessor: joi.object({
                 builtinAssessorName: joi.string().valid('Medianstop', 'Curvefitting'),
@@ -134,7 +134,7 @@ export namespace ValidationSchemas {
                 className: joi.string(),
                 classArgs: joi.any(),
                 gpuNum: joi.number().min(0),
-                checkpointDir: joi.string()
+                checkpointDir: joi.string().allow('')
             }),
             clusterMetaData: joi.array().items(joi.object({
                 key: joi.string(),
@@ -149,7 +149,7 @@ export namespace ValidationSchemas {
         body: {
             id: joi.string().required(),
             revision: joi.number().min(0).required(),
-            params: joi.object(STARTEXPERIMENT.body).required(),
+            params: joi.object(STARTEXPERIMENT.body),
             execDuration: joi.number().required(),
             startTime: joi.number(),
             endTime: joi.number(),

src/nni_manager/rest_server/test/mockedNNIManager.ts

@@ -101,13 +101,7 @@ export class MockedNNIManager extends Manager {
     }
 
     public setClusterMetadata(key: string, value: string): Promise<void> {
-        const deferred: Deferred<void> = new Deferred<void>();
-        if (key === 'exception_test_key') {
-            deferred.reject(new Error('Test Error'));
-        }
-        deferred.resolve();
-
-        return deferred.promise;
+        return Promise.resolve();
     }
 
     public getTrialJob(trialJobId: string): Promise<TrialJobInfo> {

src/nni_manager/rest_server/test/restserver.test.ts

@@ -133,7 +133,7 @@ describe('Unit test for rest server', () => {
         });
     });
 
-    it('Test PUT experiment/cluster-metadata exception', (done: Mocha.Done) => {
+    it('Test PUT experiment/cluster-metadata bad key', (done: Mocha.Done) => {
         const req: request.Options = {
             uri: `${ROOT_URL}/experiment/cluster-metadata`,
             method: 'PUT',
@@ -146,7 +146,7 @@ describe('Unit test for rest server', () => {
             if (err) {
                 assert.fail(err.message);
             } else {
-                expect(res.statusCode).to.equal(500);
+                expect(res.statusCode).to.equal(400);
             }
             done();
         });