Merge branch 'add_visualization_docstring' into 'master'

add_visualization_docstring

See merge request open-mmlab/mmdet.3d!129

mmdet3d/datasets/kitti_dataset.py

@@ -642,6 +642,7 @@ class KittiDataset(Custom3DDataset):
             data_info = self.data_infos[i]
             pts_path = data_info['point_cloud']['velodyne_path']
             file_name = osp.split(pts_path)[-1].split('.')[0]
+            # for now we convert points into depth mode
             points = example['points'][0]._data.numpy()
             points = points[..., [1, 0, 2]]
             points[..., 0] *= -1

mmdet3d/datasets/nuscenes_dataset.py

@@ -476,6 +476,7 @@ class NuScenesDataset(Custom3DDataset):
             data_info = self.data_infos[i]
             pts_path = data_info['lidar_path']
             file_name = osp.split(pts_path)[-1].split('.')[0]
+            # for now we convert points into depth mode
             points = points[..., [1, 0, 2]]
             points[..., 0] *= -1
             inds = result['pts_bbox']['scores_3d'] > 0.1

mmdet3d/models/detectors/base.py

@@ -59,6 +59,13 @@ class Base3DDetector(BaseDetector):
             return self.forward_test(**kwargs)
 
     def show_results(self, data, result, out_dir):
+        """Results visualization.
+
+        Args:
+            data (dict): Input points and info.
+            result (dict): Prediction results.
+            out_dir (str): Output directory of visualization result.
+        """
         points = data['points'][0]._data[0][0].numpy()
         pts_filename = data['img_metas'][0]._data[0][0]['pts_filename']
         file_name = osp.split(pts_filename)[-1].split('.')[0]

mmdet3d/models/detectors/mvx_two_stage.py

@@ -403,6 +403,13 @@ class MVXTwoStageDetector(Base3DDetector):
         return merged_bboxes
 
     def show_results(self, data, result, out_dir):
+        """Results visualization.
+
+        Args:
+            data (dict): Input points and info.
+            result (dict): Prediction results.
+            out_dir (str): Output directory of visualization result.
+        """
         points = data['points'][0]._data[0][0].numpy()
         pts_filename = data['img_metas'][0]._data[0][0]['pts_filename']
         file_name = osp.split(pts_filename)[-1].split('.')[0]