Unverified Commit 751ac205 authored by ChaimZhu's avatar ChaimZhu Committed by GitHub
Browse files

fix visualization bugs in mono3d (#1066)

parent 8239416f
...@@ -132,7 +132,7 @@ def show_seg_result(points, ...@@ -132,7 +132,7 @@ def show_seg_result(points,
filename, filename,
palette, palette,
ignore_index=None, ignore_index=None,
show=True, show=False,
snapshot=False): snapshot=False):
"""Convert results into format that is directly readable for meshlab. """Convert results into format that is directly readable for meshlab.
...@@ -206,7 +206,7 @@ def show_multi_modality_result(img, ...@@ -206,7 +206,7 @@ def show_multi_modality_result(img,
filename, filename,
box_mode='lidar', box_mode='lidar',
img_metas=None, img_metas=None,
show=True, show=False,
gt_bbox_color=(61, 102, 255), gt_bbox_color=(61, 102, 255),
pred_bbox_color=(241, 101, 72)): pred_bbox_color=(241, 101, 72)):
"""Convert multi-modality detection results into 2D results. """Convert multi-modality detection results into 2D results.
......
...@@ -202,7 +202,8 @@ class KittiMonoDataset(NuScenesMonoDataset): ...@@ -202,7 +202,8 @@ class KittiMonoDataset(NuScenesMonoDataset):
pklfile_prefix=None, pklfile_prefix=None,
submission_prefix=None, submission_prefix=None,
show=False, show=False,
out_dir=None): out_dir=None,
pipeline=None):
"""Evaluation in KITTI protocol. """Evaluation in KITTI protocol.
Args: Args:
...@@ -220,6 +221,8 @@ class KittiMonoDataset(NuScenesMonoDataset): ...@@ -220,6 +221,8 @@ class KittiMonoDataset(NuScenesMonoDataset):
Default: False. Default: False.
out_dir (str, optional): Path to save the visualization results. out_dir (str, optional): Path to save the visualization results.
Default: None. Default: None.
pipeline (list[dict], optional): raw data loading for showing.
Default: None.
Returns: Returns:
dict[str, float]: Results of each evaluation metric. dict[str, float]: Results of each evaluation metric.
...@@ -256,8 +259,8 @@ class KittiMonoDataset(NuScenesMonoDataset): ...@@ -256,8 +259,8 @@ class KittiMonoDataset(NuScenesMonoDataset):
if tmp_dir is not None: if tmp_dir is not None:
tmp_dir.cleanup() tmp_dir.cleanup()
if show: if show or out_dir:
self.show(results, out_dir) self.show(results, out_dir, show=show, pipeline=pipeline)
return ap_dict return ap_dict
def bbox2result_kitti(self, def bbox2result_kitti(self,
......
...@@ -12,7 +12,7 @@ from mmdet3d.datasets.pipelines import (Collect3D, DefaultFormatBundle3D, ...@@ -12,7 +12,7 @@ from mmdet3d.datasets.pipelines import (Collect3D, DefaultFormatBundle3D,
PointSegClassMapping) PointSegClassMapping)
# yapf: enable # yapf: enable
from mmdet.datasets.builder import PIPELINES from mmdet.datasets.builder import PIPELINES
from mmdet.datasets.pipelines import LoadImageFromFile from mmdet.datasets.pipelines import LoadImageFromFile, MultiScaleFlipAug
def is_loading_function(transform): def is_loading_function(transform):
...@@ -40,12 +40,12 @@ def is_loading_function(transform): ...@@ -40,12 +40,12 @@ def is_loading_function(transform):
return False return False
if obj_cls in loading_functions: if obj_cls in loading_functions:
return True return True
if obj_cls in (MultiScaleFlipAug3D, ): if obj_cls in (MultiScaleFlipAug3D, MultiScaleFlipAug):
return None return None
elif callable(transform): elif callable(transform):
if isinstance(transform, loading_functions): if isinstance(transform, loading_functions):
return True return True
if isinstance(transform, MultiScaleFlipAug3D): if isinstance(transform, (MultiScaleFlipAug3D, MultiScaleFlipAug)):
return None return None
return False return False
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment