CONTRIBUTING.md 2.22 KB
Newer Older
Zaida Zhou's avatar
Zaida Zhou committed
1
## Contributing to OpenMMLab
Kai Chen's avatar
Kai Chen committed
2
3
4

All kinds of contributions are welcome, including but not limited to the following.

5
6
7
- Fix typo or bugs
- Add documentation or translate the documentation into other languages
- Add new features and components
Kai Chen's avatar
Kai Chen committed
8

Zaida Zhou's avatar
Zaida Zhou committed
9
### Workflow
Kai Chen's avatar
Kai Chen committed
10

11
1. fork and pull the latest OpenMMLab repository
Kai Chen's avatar
Kai Chen committed
12
13
14
15
2. checkout a new branch (do not use master branch for PRs)
3. commit your changes
4. create a PR

Zaida Zhou's avatar
Zaida Zhou committed
16
17
18
```{note}
If you plan to add some new features that involve large changes, it is encouraged to open an issue for discussion first.
```
19

Zaida Zhou's avatar
Zaida Zhou committed
20
### Code style
Kai Chen's avatar
Kai Chen committed
21

Zaida Zhou's avatar
Zaida Zhou committed
22
#### Python
Kai Chen's avatar
Kai Chen committed
23

Kai Chen's avatar
Kai Chen committed
24
25
26
We adopt [PEP8](https://www.python.org/dev/peps/pep-0008/) as the preferred code style.

We use the following tools for linting and formatting:
Kai Chen's avatar
Kai Chen committed
27

28
- [flake8](https://github.com/PyCQA/flake8): A wrapper around some linter tools.
29
- [isort](https://github.com/timothycrosley/isort): A Python utility to sort imports.
30
31
32
- [yapf](https://github.com/google/yapf): A formatter for Python files.
- [codespell](https://github.com/codespell-project/codespell): A Python utility to fix common misspellings in text files.
- [mdformat](https://github.com/executablebooks/mdformat): Mdformat is an opinionated Markdown formatter that can be used to enforce a consistent style in Markdown files.
33
- [docformatter](https://github.com/myint/docformatter): A formatter to format docstring.
Kai Chen's avatar
Kai Chen committed
34

35
36
Style configurations of yapf and isort can be found in [setup.cfg](./setup.cfg).

37
38
We use [pre-commit hook](https://pre-commit.com/) that checks and formats for `flake8`, `yapf`, `isort`, `trailing whitespaces`, `markdown files`,
fixes `end-of-files`, `double-quoted-strings`, `python-encoding-pragma`, `mixed-line-ending`, sorts `requirments.txt` automatically on every commit.
39
40
41
42
The config for a pre-commit hook is stored in [.pre-commit-config](./.pre-commit-config.yaml).

After you clone the repository, you will need to install initialize pre-commit hook.

Kai Chen's avatar
Kai Chen committed
43
```shell
44
45
46
47
pip install -U pre-commit
```

From the repository folder
Kai Chen's avatar
Kai Chen committed
48
49

```shell
50
51
52
53
54
pre-commit install
```

After this on every commit check code linters and formatter will be enforced.

55
> Before you create a PR, make sure that your code lints and is formatted by yapf.
Kai Chen's avatar
Kai Chen committed
56

Zaida Zhou's avatar
Zaida Zhou committed
57
#### C++ and CUDA
Kai Chen's avatar
Kai Chen committed
58

Kai Chen's avatar
Kai Chen committed
59
We follow the [Google C++ Style Guide](https://google.github.io/styleguide/cppguide.html).