Commit 8044c7b4 authored by Jared Casper's avatar Jared Casper
Browse files

Update arguments checks.

hidden_size % attention_heads == 0 is handled above when dealing with kv_channels.

Adding check for decoder sequence length.
parent 2ff004ac
...@@ -213,9 +213,10 @@ def parse_args(extra_args_provider=None, defaults={}, ...@@ -213,9 +213,10 @@ def parse_args(extra_args_provider=None, defaults={},
assert args.encoder_seq_length is not None assert args.encoder_seq_length is not None
args.seq_length = args.encoder_seq_length args.seq_length = args.encoder_seq_length
assert args.hidden_size % args.num_attention_heads == 0
if args.seq_length is not None: if args.seq_length is not None:
assert args.max_position_embeddings >= args.seq_length assert args.max_position_embeddings >= args.seq_length
if args.decoder_seq_length is not None:
assert args.max_position_embeddings >= args.decoder_seq_length
if args.lr is not None: if args.lr is not None:
assert args.min_lr <= args.lr assert args.min_lr <= args.lr
if args.save is not None: if args.save is not None:
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment