Skip to content
GitLab
Menu
Projects
Groups
Snippets
Loading...
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
Menu
Open sidebar
OpenDAS
Megatron-LM
Commits
69f3249f
Commit
69f3249f
authored
Oct 11, 2022
by
Vijay Korthikanti
Browse files
address review comments
parent
cbf8250b
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
6 additions
and
4 deletions
+6
-4
megatron/arguments.py
megatron/arguments.py
+4
-2
megatron/mpu/initialize.py
megatron/mpu/initialize.py
+2
-2
No files found.
megatron/arguments.py
View file @
69f3249f
...
@@ -226,10 +226,12 @@ def validate_args(args, defaults={}):
...
@@ -226,10 +226,12 @@ def validate_args(args, defaults={}):
'and lr-warmup-samples'
'and lr-warmup-samples'
if
args
.
num_layers
is
not
None
:
if
args
.
num_layers
is
not
None
:
assert
args
.
encoder_num_layers
is
None
assert
args
.
encoder_num_layers
is
None
,
\
'cannot have both num-layers and encoder-num-layers specified'
args
.
encoder_num_layers
=
args
.
num_layers
args
.
encoder_num_layers
=
args
.
num_layers
else
:
else
:
assert
args
.
encoder_num_layers
is
not
None
assert
args
.
encoder_num_layers
is
not
None
,
\
'either num-layers or encoder-num-layers should be specified'
args
.
num_layers
=
args
.
encoder_num_layers
args
.
num_layers
=
args
.
encoder_num_layers
# Check required arguments.
# Check required arguments.
...
...
megatron/mpu/initialize.py
View file @
69f3249f
...
@@ -330,9 +330,9 @@ def get_num_layers(args, is_encoder_and_decoder_model, is_decoder=False):
...
@@ -330,9 +330,9 @@ def get_num_layers(args, is_encoder_and_decoder_model, is_decoder=False):
)
)
num_ranks_in_decoder
=
args
.
transformer_pipeline_model_parallel_size
-
num_ranks_in_encoder
num_ranks_in_decoder
=
args
.
transformer_pipeline_model_parallel_size
-
num_ranks_in_encoder
assert
args
.
encoder_num_layers
%
num_ranks_in_encoder
==
0
,
\
assert
args
.
encoder_num_layers
%
num_ranks_in_encoder
==
0
,
\
'num_layers (%d) must be divisible by number of ranks given to encoder (%d)'
%
(
args
.
encoder_num_layers
,
num_ranks_in_encoder
)
'
encoder_
num_layers (%d) must be divisible by number of ranks given to encoder (%d)'
%
(
args
.
encoder_num_layers
,
num_ranks_in_encoder
)
assert
args
.
decoder_num_layers
%
num_ranks_in_decoder
==
0
,
\
assert
args
.
decoder_num_layers
%
num_ranks_in_decoder
==
0
,
\
'num_layers (%d) must be divisible by number of ranks given to decoder (%d)'
%
(
args
.
decoder_num_layers
,
num_ranks_in_decoder
)
'
decoder_
num_layers (%d) must be divisible by number of ranks given to decoder (%d)'
%
(
args
.
decoder_num_layers
,
num_ranks_in_decoder
)
if
is_pipeline_stage_before_split
():
if
is_pipeline_stage_before_split
():
num_layers
=
(
num_layers
=
(
0
0
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
.
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment