Skip to content
GitLab
Menu
Projects
Groups
Snippets
Loading...
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
Menu
Open sidebar
OpenDAS
ktransformers
Commits
ec12429c
Unverified
Commit
ec12429c
authored
Apr 02, 2025
by
Atream
Committed by
GitHub
Apr 02, 2025
Browse files
Merge pull request #1005 from fishingfly/improve/backend-error-msg
fix: refine backend error message to include ROCM_HOME
parents
ac95b6c7
7549ff33
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
9 additions
and
9 deletions
+9
-9
setup.py
setup.py
+9
-9
No files found.
setup.py
View file @
ec12429c
...
...
@@ -69,17 +69,17 @@ class VersionInfo:
def
get_rocm_bare_metal_version
(
self
,
rocm_dir
):
"""
Get the ROCm version from the ROCm installation directory.
Args:
rocm_dir: Path to the ROCm installation directory
Returns:
A string representation of the ROCm version (e.g., "63" for ROCm 6.3)
"""
try
:
# Try using rocm_agent_enumerator to get version info
raw_output
=
subprocess
.
check_output
(
[
rocm_dir
+
"/bin/rocminfo"
,
"--version"
],
[
rocm_dir
+
"/bin/rocminfo"
,
"--version"
],
universal_newlines
=
True
,
stderr
=
subprocess
.
STDOUT
)
# Extract version number from output
...
...
@@ -92,7 +92,7 @@ class VersionInfo:
except
(
subprocess
.
CalledProcessError
,
FileNotFoundError
):
# If rocminfo --version fails, try alternative methods
pass
try
:
# Try reading version from release file
with
open
(
os
.
path
.
join
(
rocm_dir
,
"share/doc/hip/version.txt"
),
"r"
)
as
f
:
...
...
@@ -102,7 +102,7 @@ class VersionInfo:
return
rocm_version
except
(
FileNotFoundError
,
IOError
):
pass
# If all else fails, try to extract from directory name
dir_name
=
os
.
path
.
basename
(
os
.
path
.
normpath
(
rocm_dir
))
match
=
re
.
search
(
r
'rocm-(\d+\.\d+)'
,
dir_name
)
...
...
@@ -111,7 +111,7 @@ class VersionInfo:
version
=
parse
(
version_str
)
rocm_version
=
f
"
{
version
.
major
}{
version
.
minor
}
"
return
rocm_version
# Fallback to extracting from hipcc version
try
:
raw_output
=
subprocess
.
check_output
(
...
...
@@ -126,7 +126,7 @@ class VersionInfo:
return
rocm_version
except
(
subprocess
.
CalledProcessError
,
FileNotFoundError
):
pass
# If we still can't determine the version, raise an error
raise
ValueError
(
f
"Could not determine ROCm version from directory:
{
rocm_dir
}
"
)
...
...
@@ -317,10 +317,10 @@ class CMakeBuild(BuildExtension):
elif
ROCM_HOME
is
not
None
:
cmake_args
+=
[
"-DKTRANSFORMERS_USE_ROCM=ON"
]
else
:
raise
ValueError
(
"Unsupported backend: CUDA_HOME and
MUSA
_HOME are not set."
)
raise
ValueError
(
"Unsupported backend: CUDA_HOME
, MUSA_HOME,
and
ROCM
_HOME are not set."
)
# log cmake_args
print
(
"CMake args:"
,
cmake_args
)
build_args
=
[]
if
"CMAKE_ARGS"
in
os
.
environ
:
cmake_args
+=
[
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
.
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment