Skip to content
GitLab
Menu
Projects
Groups
Snippets
Loading...
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
Menu
Open sidebar
OpenDAS
FastMoE
Commits
08e08319
Commit
08e08319
authored
Feb 25, 2021
by
Jiezhong Qiu
Browse files
fix bug in wrong gradient of bias in FMoELinear
parent
804999f1
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
11 additions
and
2 deletions
+11
-2
fmoe/layers.py
fmoe/layers.py
+11
-2
No files found.
fmoe/layers.py
View file @
08e08319
...
@@ -61,8 +61,17 @@ class FMoELinear(nn.Module):
...
@@ -61,8 +61,17 @@ class FMoELinear(nn.Module):
'''
'''
x
=
MOELinear
.
apply
(
inp
,
self
.
weight
,
fwd_expert_count
)
x
=
MOELinear
.
apply
(
inp
,
self
.
weight
,
fwd_expert_count
)
if
self
.
bias
is
not
None
:
if
self
.
bias
is
not
None
:
bias
=
torch
.
repeat_interleave
(
self
.
bias
,
# TODO: torch.repeat_interleave seems have wrong behavior
fwd_expert_count
.
to
(
self
.
bias
.
device
),
dim
=
0
)
# in backward, leading to incorrect gradient for bias.
# Thus we use a for-loop to manually expand the bias term.
# This part should finally goes to MOELinear.apply.
#bias = torch.repeat_interleave(self.bias,
# fwd_expert_count.to(self.bias.device), dim=0)
bias
=
[]
for
i
in
range
(
self
.
num_expert
):
if
fwd_expert_count
[
i
]
>
0
:
bias
.
append
(
self
.
bias
[
i
].
unsqueeze
(
0
).
expand
(
fwd_expert_count
[
i
],
-
1
))
bias
=
torch
.
cat
(
bias
,
dim
=
0
)
x
=
x
+
bias
x
=
x
+
bias
return
x
return
x
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
.
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment