Commit 8a8c0691 authored by Naman Goyal's avatar Naman Goyal Committed by Facebook Github Bot
Browse files

fix cython dependency in the setup (#847)

Summary:
Fixes broken build for `pytext` https://github.com/pytorch/fairseq/commit/4fc39538aec5141aa41f5d6d7dc0097e7c0f7b48

Earlier version of setup tools required `cython` to be installed before even starting setup.py. This one fixes it.
More details: https://github.com/pypa/setuptools/blob/master/CHANGES.rst#180
and https://stackoverflow.com/questions/37471313/setup-requires-with-cython
Pull Request resolved: https://github.com/fairinternal/fairseq-py/pull/847

Differential Revision: D16997450

fbshipit-source-id: 5f65026c228a1b94280ca73937078ee3e21ce4f8
parent 833f053d
...@@ -5,7 +5,6 @@ ...@@ -5,7 +5,6 @@
# LICENSE file in the root directory of this source tree. # LICENSE file in the root directory of this source tree.
from setuptools import setup, find_packages, Extension from setuptools import setup, find_packages, Extension
from Cython.Build import cythonize
import sys import sys
...@@ -28,8 +27,8 @@ bleu = Extension( ...@@ -28,8 +27,8 @@ bleu = Extension(
extra_compile_args=extra_compile_args, extra_compile_args=extra_compile_args,
) )
token_block_utils = cythonize("fairseq/data/token_block_utils_fast.pyx") token_block_utils = [Extension("fairseq.data.token_block_utils_fast", ["fairseq/data/token_block_utils_fast.pyx"])]
data_utils_fast = cythonize("fairseq/data/data_utils_fast.pyx", language="c++") data_utils_fast = [Extension("fairseq.data.data_utils_fast", ["fairseq/data/data_utils_fast.pyx"], language="c++")]
setup( setup(
name='fairseq', name='fairseq',
...@@ -45,6 +44,10 @@ setup( ...@@ -45,6 +44,10 @@ setup(
], ],
long_description=readme, long_description=readme,
long_description_content_type='text/markdown', long_description_content_type='text/markdown',
setup_requires=[
'cython',
'setuptools>=18.0',
],
install_requires=[ install_requires=[
'cffi', 'cffi',
'fastBPE', 'fastBPE',
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment