Commit 8a2e6e81 authored by Jay Mahadeokar's avatar Jay Mahadeokar Committed by Facebook Github Bot
Browse files

add option to specify lr-threshold while using lr-on-plateau strategy

Summary: As in title.

Reviewed By: skritika

Differential Revision: D15299135

fbshipit-source-id: 2fd513b32c0ab41911cdf0b0186f6c3bb5256285
parent 47fbc491
...@@ -22,7 +22,8 @@ class ReduceLROnPlateau(FairseqLRScheduler): ...@@ -22,7 +22,8 @@ class ReduceLROnPlateau(FairseqLRScheduler):
' Consider --lr-scheduler=fixed instead.' ' Consider --lr-scheduler=fixed instead.'
) )
self.lr_scheduler = torch.optim.lr_scheduler.ReduceLROnPlateau( self.lr_scheduler = torch.optim.lr_scheduler.ReduceLROnPlateau(
self.optimizer.optimizer, patience=0, factor=args.lr_shrink) self.optimizer.optimizer, patience=0, factor=args.lr_shrink,
threshold=args.lr_threshold)
@staticmethod @staticmethod
def add_args(parser): def add_args(parser):
...@@ -30,6 +31,9 @@ class ReduceLROnPlateau(FairseqLRScheduler): ...@@ -30,6 +31,9 @@ class ReduceLROnPlateau(FairseqLRScheduler):
# fmt: off # fmt: off
parser.add_argument('--lr-shrink', default=0.1, type=float, metavar='LS', parser.add_argument('--lr-shrink', default=0.1, type=float, metavar='LS',
help='shrink factor for annealing, lr_new = (lr * lr_shrink)') help='shrink factor for annealing, lr_new = (lr * lr_shrink)')
parser.add_argument('--lr-threshold', default=1e-4, type=float, metavar='LT',
help='Threshold for measuring the new optimum, \
to only focus on significant changes')
# fmt: on # fmt: on
def state_dict(self): def state_dict(self):
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment