Commit 4812f64b authored by Dmytro Okhonko's avatar Dmytro Okhonko Committed by Facebook Github Bot
Browse files

Fix method has same name as property

Summary:
Training is failing sometimes because `self.collater` can be both method and property for AsrDataset
https://github.com/pytorch/fairseq/issues/1036

Reviewed By: jcai1

Differential Revision: D16919945

fbshipit-source-id: b34ba54e4dae315b7c723996610a348a8e3031af
parent c81fed46
...@@ -72,7 +72,7 @@ class AsrDataset(FairseqDataset): ...@@ -72,7 +72,7 @@ class AsrDataset(FairseqDataset):
frame_shift=self.frame_shift frame_shift=self.frame_shift
) )
output_cmvn = data_utils.apply_mv_norm(output) output_cmvn = data_utils.apply_mv_norm(output)
self.collater = Seq2SeqCollater( self.s2s_collater = Seq2SeqCollater(
0, 1, pad_index=self.tgt_dict.pad(), 0, 1, pad_index=self.tgt_dict.pad(),
eos_index=self.tgt_dict.eos(), move_eos_to_beginning=True eos_index=self.tgt_dict.eos(), move_eos_to_beginning=True
) )
...@@ -91,7 +91,7 @@ class AsrDataset(FairseqDataset): ...@@ -91,7 +91,7 @@ class AsrDataset(FairseqDataset):
Returns: Returns:
dict: a mini-batch suitable for forwarding with a Model dict: a mini-batch suitable for forwarding with a Model
""" """
return self.collater.collate(samples) return self.s2s_collater.collate(samples)
def num_tokens(self, index): def num_tokens(self, index):
return self.frame_sizes[index] return self.frame_sizes[index]
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment