"scripts/download_models.py" did not exist on "75b4375dbd60f5ac8489a59b6a8e455a6e0da2ac"
  • Liezl Puzon's avatar
    Explicitly list out generation args for backtranslation dataset · 86e93f2b
    Liezl Puzon authored
    Summary:
    Using argparse Namespace hides the actual args that are expected and makes code harder to read.
    
    Note the difference in style for the args list
    
        def __init__(
            self,
            tgt_dataset,
            tgt_dict,
            backtranslation_model,
            unkpen,
            sampling,
            beam,
            max_len_a,
            max_len_b,
        ):
    
    instead of
    
        def __init__(
            self, tgt_dataset, tgt_dict, backtranslation_model, unkpen, sampling,
            beam,  max_len_a, max_len_b,
        ):
    
    Reviewed By: dpacgopinath
    
    Differential Revision: D10152331
    
    fbshipit-source-id: 6539ccba09d48acf23759996b7e32fb329b3e3f6
    86e93f2b
test_backtranslation_dataset.py 2.14 KB