Skip to content
GitLab
Menu
Projects
Groups
Snippets
Loading...
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
Menu
Open sidebar
OpenDAS
fairscale
Commits
f87255d5
You need to sign in or sign up before continuing.
Unverified
Commit
f87255d5
authored
Feb 05, 2023
by
Ikko Eltociear Ashimine
Committed by
GitHub
Feb 04, 2023
Browse files
[fix] typo in flatten_params_wrapper.py (#1103)
heirarchy -> hierarchy
parent
4a98000c
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
2 additions
and
2 deletions
+2
-2
fairscale/nn/misc/flatten_params_wrapper.py
fairscale/nn/misc/flatten_params_wrapper.py
+2
-2
No files found.
fairscale/nn/misc/flatten_params_wrapper.py
View file @
f87255d5
...
@@ -58,8 +58,8 @@ class FlatParameter(nn.Parameter):
...
@@ -58,8 +58,8 @@ class FlatParameter(nn.Parameter):
raise
ValueError
(
"List items need to be Parameter types"
)
raise
ValueError
(
"List items need to be Parameter types"
)
# Flattening involves (1) making a tensor flat (i.e. single dimensional) and (2) making a module
# Flattening involves (1) making a tensor flat (i.e. single dimensional) and (2) making a module
# h
e
irarchy flat (using a single tensor to replace a tree of tensors). Therefore,
# hi
e
rarchy flat (using a single tensor to replace a tree of tensors). Therefore,
# adding back nesting and h
e
irarchy is counter-productive. If nesting is encountered
# adding back nesting and hi
e
rarchy is counter-productive. If nesting is encountered
# in the future, the reasonable thing to do is likely for the top level FlatParameter to
# in the future, the reasonable thing to do is likely for the top level FlatParameter to
# absorb the nested one and keep the result flat, free from hierarchy.
# absorb the nested one and keep the result flat, free from hierarchy.
if
any
(
isinstance
(
p
,
FlatParameter
)
for
p
in
params
):
if
any
(
isinstance
(
p
,
FlatParameter
)
for
p
in
params
):
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
.
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment