• Rahul Iyer's avatar
    Fix pre-commit hook failures (#756) · 31d600cc
    Rahul Iyer authored
    Pre-commit hook fails when run on all files for three reasons:
    (see trace below)
    
    1. Trailing whitespace on multiple files
    2. mypy fails to load numpy and then subsequently fails to load
    LazyModule from pipe.py
    3. isort sees issues with known_third_party packages
    
    ```
    > pre-commit run --all-files
    
    Trim Trailing Whitespace.................................................Failed
    - hook id: trailing-whitespace
    - exit code: 1
    - files were modified by this hook
    
    Fixing docs/source/conf.py
    Fixing fairscale/experimental/nn/auto_shard.py
    Fixing docs/source/deep_dive/activation_checkpointing.rst
    Fixing docs/source/tutorials/pipe.rst
    Fixing docs/source/installation_instructions.rst
    Fixing docs/source/deep_dive/pipeline_parallelism.rst
    Fixing docs/source/tutorials/activation_checkpointing.rst
    Fixing docs/source/tutorials/offload_model.rst
    Fixing docs/source/deep_dive/oss_sdp_fsdp.rst
    Fixing docs/source/what_is_fairscale.rst
    Fixing CHANGELOG.md
    Fixing fairscale/experimental/nn/offload.py
    Fixing docs/source/index.rst
    Fixing docs/source/deep_dive/adascale.rst
    Fixing README.md
    Fixing docs/source/tutorials/oss.rst
    Fixing docs/source/deep_dive/offload.rst
    
    Check python ast.........................................................Passed
    Check for merge conflicts................................................Passed
    Don't commit to branch...................................................Passed
    Check for added large files..............................................Passed
    Fix End of Files.........................................................Failed
    - hook id: end-of-file-fixer
    - exit code: 1
    - files were modified by this hook
    
    Fixing requirements.txt
    Fixing docs/source/getting_started.rst
    Fixing docs/source/installation_instructions.rst
    Fixing codecov.yml
    Fixing docs/source/deep_dive/adascale.rst
    Fixing docs/source/tutorials/oss.rst
    Fixing docs/source/deep_dive/offload.rst
    
    black....................................................................Passed
    flake8...................................................................Passed
    seed isort known_third_party.............................................Failed
    - hook id: seed-isort-config
    - exit code: 1
    - files were modified by this hook
    isort....................................................................Passed
    mypy.....................................................................Failed
    - hook id: mypy
    - exit code: 2
    
    setup.cfg:45: error: Error importing plugin 'numpy.typing.mypy_plugin': No module named 'numpy'
    Found 1 error in 1 file (checked 197 source files)
    ```
    31d600cc
index.rst 1.15 KB