Skip to content

GitLab

Unverified Commit f19b44a9 authored by Waël Boukhobza's avatar Waël Boukhobza Committed by GitHub
Browse files

fix: handle missing span_name in logging test assertions (#2665)

parent 0bd4995d
Hide whitespace changes
Inline Side-by-side
Showing with 24 additions and 12 deletions
lib/runtime/src/logging.rs
View file @ f19b44a9
...@@ -1009,28 +1009,40 @@ pub mod tests { ...@@ -1009,28 +1009,40 @@ pub mod tests {
// Parent span has no parent_id // Parent span has no parent_id
for log_line in &lines { for log_line in &lines {
if log_line.get("span_name").unwrap().as_str().unwrap() == "parent" { if let Some(span_name) = log_line.get("span_name") {
assert!(log_line.get("parent_id").is_none()); if let Some(span_name_str) = span_name.as_str() {
if span_name_str == "parent" {
assert!(log_line.get("parent_id").is_none());
}
}
} }
} }
// Child span's parent_id is parent_span_id // Child span's parent_id is parent_span_id
for log_line in &lines { for log_line in &lines {
if log_line.get("span_name").unwrap().as_str().unwrap() == "child" { if let Some(span_name) = log_line.get("span_name") {
assert_eq!( if let Some(span_name_str) = span_name.as_str() {
log_line.get("parent_id").unwrap().as_str().unwrap(), if span_name_str == "child" {
&parent_span_id assert_eq!(
); log_line.get("parent_id").unwrap().as_str().unwrap(),
&parent_span_id
);
}
}
} }
} }
// Grandchild span's parent_id is child_span_id // Grandchild span's parent_id is child_span_id
for log_line in &lines { for log_line in &lines {
if log_line.get("span_name").unwrap().as_str().unwrap() == "grandchild" { if let Some(span_name) = log_line.get("span_name") {
assert_eq!( if let Some(span_name_str) = span_name.as_str() {
log_line.get("parent_id").unwrap().as_str().unwrap(), if span_name_str == "grandchild" {
&child_span_id assert_eq!(
); log_line.get("parent_id").unwrap().as_str().unwrap(),
&child_span_id
);
}
}
} }
} }
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment