"docs/vscode:/vscode.git/clone" did not exist on "7b941d7e29fbca99189ff73d8846cf7d5edc4024"
Unverified Commit e5557803 authored by Keiven C's avatar Keiven C Committed by GitHub
Browse files

fix: correct SGLang metrics prefix from sglang_ to sglang: (#5701)


Signed-off-by: default avatarKeiven Chang <keivenchang@users.noreply.github.com>
Co-authored-by: default avatarKeiven Chang <keivenchang@users.noreply.github.com>
parent 2d6babe5
...@@ -163,7 +163,6 @@ def setup_prometheus_registry( ...@@ -163,7 +163,6 @@ def setup_prometheus_registry(
endpoint=generate_endpoint, endpoint=generate_endpoint,
registry=registry, registry=registry,
metric_prefix_filters=["sglang:"], metric_prefix_filters=["sglang:"],
add_prefix="sglang_",
) )
return registry return registry
......
...@@ -634,8 +634,8 @@ class MetricsPayload(BasePayload): ...@@ -634,8 +634,8 @@ class MetricsPayload(BasePayload):
metrics_to_check.append( metrics_to_check.append(
MetricCheck( MetricCheck(
# Check: Minimum count of unique sglang:* metrics # Check: Minimum count of unique sglang:* metrics
name="sglang_*", name="sglang:*",
pattern=lambda name: r"^sglang_\w+", pattern=lambda name: r"^sglang:\w+",
validator=lambda value: len(set(value)) validator=lambda value: len(set(value))
>= 20, # 80% of typical ~25 sglang metrics (excluding _bucket) as of 2025-10-22 (but will grow) >= 20, # 80% of typical ~25 sglang metrics (excluding _bucket) as of 2025-10-22 (but will grow)
error_msg=lambda name, value: f"Expected at least 20 unique sglang:* metrics, but found only {len(set(value))}", error_msg=lambda name, value: f"Expected at least 20 unique sglang:* metrics, but found only {len(set(value))}",
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment